Bugfix for Array.insertManyAt returns original array for empty inserion (#18352) #18353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
❗ Release notes required
|
Contributor
|
Hi @muqiuhan - thanks for the contribution. Could you please add a test for the fix? |
Contributor
Author
|
On Mon, 03 Mar 2025 03:21:35 -0800 Petr ***@***.***> wrote:
psfinaki left a comment (dotnet/fsharp#18353)
Hi @muqiuhan - thanks for the contribution. Could you please add a
test for the fix?
Sure, I added a test to cover this change in `Array.insertManyAt`
|
Contributor
|
👍 |
psfinaki
approved these changes
Mar 4, 2025
Contributor
psfinaki
left a comment
psfinaki
left a comment
There was a problem hiding this comment.
Alrighty, I think this is the right fix.
Please add release notes and optionally a comment for the change, referencing the issue.
Thanks!
Contributor
|
In my heart, this isn't a bug, inserting an empty array into an array should not result in a copy, however, both append and concat with empty arrays do, and so I must reluctantly approve. Array.concat [||] |
…ion (dotnet#18352) - Update test, release note and comment for Array.InsertManyAt
T-Gro
approved these changes
Mar 10, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
array.Clone()to fix the bug thatArray.insertManyAtdirectly returning source array when the values inserted are empty.Checklist