Skip to content

Exclude FileSystemTests from parallelization #18153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Exclude FileSystemTests from parallelization #18153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a77a07
exempt FileSystemTests from parallelization
majocha Dec 17, 2024
37be9c1
tune down linux test parallelism
majocha Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ function Test() {
projectname="${projectname%.*}"
testlogpath="$artifacts_dir/TestResults/$configuration/${projectname}_$targetframework.xml"
args="test \"$testproject\" --no-restore --no-build -c $configuration -f $targetframework --test-adapter-path . --logger \"xunit;LogFilePath=$testlogpath\" --blame-hang-timeout 5minutes --results-directory $artifacts_dir/TestResults/$configuration -p:vstestusemsbuildoutput=false"
args+=" -- xUnit.MaxParallelThreads=3"
args+=" -- xUnit.MaxParallelThreads=2"
"$DOTNET_INSTALL_DIR/dotnet" $args || exit $?
}

Expand Down
6 changes: 3 additions & 3 deletions tests/FSharp.Compiler.Service.Tests/FileSystemTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
module FSharp.Compiler.Service.Tests.FileSystemTests
// FileSystem is a global shared resource.
[<Xunit.Collection(nameof FSharp.Test.NotThreadSafeResourceCollection)>]
module FSharp.Compiler.Service.Tests.FileSystemTests

open Xunit
open FSharp.Test.Assert
Expand All @@ -25,8 +27,6 @@ let file2 = """
module File2
let B = File1.A + File1.A"""

// FileSystem is a global shared resource.
[<Collection(nameof NotThreadSafeResourceCollection)>]
type internal MyFileSystem() =
inherit DefaultFileSystem()
static member FilesCache = dict [(fileName1, file1); (fileName2, file2)]
Expand Down
Loading