Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing TailCall warning in Sequential in use scope, #17897 #17927

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Fix missing TailCall warning in Sequential in use scope, #17897 #17927

merged 4 commits into from
Oct 29, 2024

Conversation

dawedawe
Copy link
Contributor

Description

Fixes #17897

Checklist

  • Test cases added
  • Performance benchmarks added in case of performance changes
  • Release notes entry updated:

@dawedawe dawedawe requested a review from a team as a code owner October 25, 2024 21:54
@github-actions GitHub Actions
Copy link
Contributor

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@T-Gro T-Gro enabled auto-merge (squash) October 29, 2024 09:08
@T-Gro T-Gro merged commit d566f53 into dotnet:main Oct 29, 2024
32 checks passed
@dawedawe dawedawe deleted the fix_17897 branch October 29, 2024 14:25
This was referenced Oct 31, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Nov 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@edgarfgp edgarfgp edgarfgp approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using TailCallAttribute on a function that uses use does not result in expected warning
4 participants
@dawedawe @vzarytovskii @edgarfgp @T-Gro