- 
                Notifications
    You must be signed in to change notification settings 
- Fork 834
Reuse typechecking results - stage 1 #17898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse typechecking results - stage 1 #17898
Conversation
| ❗ Release notes required
 Warning No PR link found in some release notes, please consider adding it. 
 | 
        
          
                tests/benchmarks/FCSBenchmarks/CompilerServiceBenchmarks/ReuseTypecheckingResultsBenchmarks.fs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | @T-Gro PTAL, this is an early stage so I mostly just wanted to discuss the questions I raised in the comments, so that we go in the agreed direction. | 
| It seems like this is going to rely/build on top of  
 | 
| @edgarfgp so we'll need to discuss this - personally I'd like to turn graph-checking on. Now (like, before Xmas) is a rather good time - we can catch some bugs there before the next big release. It's somewhat scaring but, well, just this probably shouldn't be stopping us 👀 Graph-checking and reusing typechecking results can test each other and I'd say we should use this benefit here. I am not speaking for the whole team just yet - only sharing some thoughts. We will discuss and prioritize this. | 
6df7695    to
    be247f3      
    Compare
  
    ce9c28e    to
    3275457      
    Compare
  
    7cf4e2f    to
    84bbc6a      
    Compare
  
    c98053e    to
    e563a93      
    Compare
  
    e563a93    to
    df866b5      
    Compare
  
    c43673d    to
    ffe4b01      
    Compare
  
    ffe4b01    to
    99991ed      
    Compare
  
    | Merging, since this goes to a feature branch now. | 
56f7ce5
      into
      
  
    dotnet:feature/reuse-typechecking-results
  
    
First part of the implementation of reusing typecheck results, as per the design doc.
This does the following:
--reusetypecheckingresults, with all the hookingNothing happens - yet - we only report related activities though.
Cache invalidation scenarios I looked at: