Skip to content

Conversation

@psfinaki
Copy link
Contributor

@psfinaki psfinaki commented Oct 18, 2024

First part of the implementation of reusing typecheck results, as per the design doc.

This does the following:

  • adds the flag --reusetypecheckingresults, with all the hooking
  • detects if there is a case to reuse typechecking results

Nothing happens - yet - we only report related activities though.

Cache invalidation scenarios I looked at:

  • changed sources
  • changed references
  • changed command line

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Warning

No PR link found in some release notes, please consider adding it.

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md No current pull request URL (#17898) found, please consider adding it

@psfinaki psfinaki changed the title Reuse typechecking results - stage 1 [WIP] Reuse typechecking results - stage 1 Oct 18, 2024
@psfinaki psfinaki requested a review from T-Gro October 18, 2024 16:31
@psfinaki
Copy link
Contributor Author

@T-Gro PTAL, this is an early stage so I mostly just wanted to discuss the questions I raised in the comments, so that we go in the agreed direction.

@edgarfgp
Copy link
Contributor

It seems like this is going to rely/build on top of graph checking have couple questions:

@psfinaki
Copy link
Contributor Author

@edgarfgp so we'll need to discuss this - personally I'd like to turn graph-checking on. Now (like, before Xmas) is a rather good time - we can catch some bugs there before the next big release.

It's somewhat scaring but, well, just this probably shouldn't be stopping us 👀 Graph-checking and reusing typechecking results can test each other and I'd say we should use this benefit here.

I am not speaking for the whole team just yet - only sharing some thoughts. We will discuss and prioritize this.

@psfinaki psfinaki marked this pull request as ready for review November 6, 2024 14:00
@psfinaki psfinaki requested a review from a team as a code owner November 6, 2024 14:00
@psfinaki psfinaki changed the title [WIP] Reuse typechecking results - stage 1 Reuse typechecking results - stage 1 Nov 6, 2024
@psfinaki psfinaki force-pushed the reuse-typecheck-a branch 2 times, most recently from ce9c28e to 3275457 Compare November 8, 2024 10:18
@psfinaki psfinaki force-pushed the reuse-typecheck-a branch 3 times, most recently from 7cf4e2f to 84bbc6a Compare November 14, 2024 16:52
@psfinaki psfinaki force-pushed the reuse-typecheck-a branch 3 times, most recently from c98053e to e563a93 Compare December 6, 2024 13:44
@psfinaki psfinaki changed the base branch from main to feature/reuse-typechecking-results December 19, 2024 15:09
@psfinaki
Copy link
Contributor Author

Merging, since this goes to a feature branch now.

@psfinaki psfinaki merged commit 56f7ce5 into dotnet:feature/reuse-typechecking-results Dec 19, 2024
33 checks passed
@psfinaki psfinaki deleted the reuse-typecheck-a branch February 10, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants