Fix 17731 - Regression, F# 9 compiler cannot find constructor for attribute

[KevinRansom]

Fix #17731

This fixes the issue: Regression, F# 9 compiler cannot find constructor for attribute.

The issue was caused by the introduction of the Attribute usage validation code.

First the validation does a pass with validation reporting disabled, it does this because:

        // 'Check' the attributes. We return the results to avoid having to re-check them in all other phases. 
        // Allow failure of constructor resolution because Vals for members in the same recursive group are not yet available

Then it does more validation, however, this time around it turns on validation reporting so that it can be notified of attribute use errors. Unfortunately the Vals for members in the same recursive group are still not available since it's only a few lines of code later.

The fix is to perform validation reporting with the constructor validation disabled.

This is okay, because the F# 8.0 code which has worked forever, just never did the pass with validation reporting enabled.

[github-actions]

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

[edgarfgp]

Thanks Kevin.