-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move attribute enforcement from v9 to preview #17739
Conversation
|
@T-Gro did you confirm that this feature is causing the regression? |
See the modified tests, the "No constructors are available for the type" issue is the same as the original. (and should not be there, because the type does have a constructor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not remember modifying this file as part of my PRs 🧐.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The negative typecheck tests do not run with langver=preview, this was only modified when the feature was enabled by default: https://github.com/dotnet/fsharp/pull/17558/files#diff-036387972a5f139a8b0f05f5b702666c5d77d961a15f0b9ac170264d79dd1c11
@vzarytovskii should be this reverted now that #17731 has been fixed ? |
Yes, it won't make it to release though |
This reverts commit b9df594.
But it will be in one of the point releases right ? |
Yeah |
No description provided.