Skip to content

Improve handling of line directives #17536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 16, 2024
Merged

Improve handling of line directives #17536

merged 3 commits into from
Aug 16, 2024

Conversation

@Martin521
Copy link
Contributor

Description

Fixes #17529
Unblocks work on #17507
Some small clean-up in the ComponentTests project

Checklist

  • Test cases added
  • Performance benchmarks added in case of performance changes
  • Release notes: not needed (no behavioral change)

@Martin521 Martin521 requested a review from a team as a code owner August 14, 2024 15:17
@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@edgarfgp edgarfgp added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Aug 15, 2024
@Martin521 Martin521 force-pushed the pre-pr-scoped-nowarn branch from 94bded2 to 8e00ef2 Compare August 16, 2024 08:14
@vzarytovskii vzarytovskii merged commit 6e6cf3e into dotnet:main Aug 16, 2024
@vzarytovskii
Copy link
Member

Thanks!

This was referenced Aug 28, 2024
Closed
Closed
@Martin521 Martin521 deleted the pre-pr-scoped-nowarn branch September 2, 2024 06:43
@dotnet-bot dotnet-bot mentioned this pull request Sep 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

+2 more reviewers

@psfinaki psfinaki psfinaki approved these changes

@edgarfgp edgarfgp edgarfgp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@KevinRansom KevinRansom

@T-Gro T-Gro

Labels

NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Internal: Line directives can lead to invalid ranges

6 participants

@Martin521 @vzarytovskii @psfinaki @edgarfgp @T-Gro @KevinRansom