Tests the scenario when calling protected static base member from static do
#17484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarfgp
added
the
NO_RELEASE_NOTES
edgarfgp
changed the title
static dostatic do
Contributor
|
psfinaki
approved these changes
Aug 2, 2024
Contributor
psfinaki
left a comment
psfinaki
left a comment
There was a problem hiding this comment.
Thanks for looking into it and testing!
@KevinRansom @vzarytovskii do we have an ambition to make it work with realsig- as well, or should we just close the issue for good?
KevinRansom
reviewed
Aug 6, 2024
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
Thank you for highlighting the super-old issue and adding these tests. I will see what can be done to make realsig- succeed in this case. We don't really want there to be a behaviour difference between on and off.
tests/FSharp.Compiler.ComponentTests/EmittedIL/RealInternalSignature/RealInternalSignature.fs
Show resolved
Hide resolved
KevinRansom
approved these changes
Aug 6, 2024
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems that the linked issue not longer happens when
--realsig+is enabled. So this PR adds tests to demonstrate thisChecklist