Skip to content

Conversation

@vzarytovskii
Copy link
Member

@vzarytovskii vzarytovskii commented May 22, 2024

Upgrades SDK to 9p5

@vzarytovskii vzarytovskii requested a review from a team as a code owner May 22, 2024 12:37
@github-actions
Copy link
Contributor

✅ No release notes required

@vzarytovskii vzarytovskii requested a review from a team as a code owner May 22, 2024 12:57
@vzarytovskii
Copy link
Member Author

vzarytovskii commented May 22, 2024

Some operator tests are failing with

System.Exception : Assertion: Expected -2147483648 but got 2147483647

When running Operators.int on p3, it yields -2147483648 for System.Single.MaxValue, and 2147483647 on the p4.

Operators.int (pretty much just conv.i4):

let inline int32 (value: ^T) =
ExplicitDynamic<(^T), int32> value
when ^T : string = ParseInt32 (castToString value)
when ^T : float = (# "conv.i4" value : int32 #)
when ^T : float32 = (# "conv.i4" value : int32 #)
when ^T : int64 = (# "conv.i4" value : int32 #)
when ^T : nativeint = (# "conv.i4" value : int32 #)
// For integers shorter that 32 bits, we sign-widen the signed integer to 32 bits
// This is a no-op on IL stack (ECMA 335 Part III 1.5 Tables 8 & 9)
when ^T : int32 = (# "" value : int32 #)
when ^T : int16 = (# "" value : int32 #)
when ^T : sbyte = (# "" value : int32 #)
when ^T : uint64 = (# "conv.i4" value : int32 #)
when ^T : uint32 = (# "" value : int32 #) // Signed<->Unsigned conversion is a no-op on IL stack
when ^T : uint16 = (# "conv.i4" value : int32 #)
when ^T : char = (# "conv.i4" value : int32 #)
when ^T : unativeint = (# "conv.i4" value : int32 #)
when ^T : byte = (# "conv.i4" value : int32 #)
when ^T : ^T = (^T : (static member op_Explicit: ^T -> int32) (value))

@dotnet dotnet deleted a comment from KevinRansom May 22, 2024
@dotnet dotnet deleted a comment from github-actions bot May 22, 2024
@vzarytovskii
Copy link
Member Author

It's likely related to changes made in dotnet/runtime#97529

@dotnet dotnet deleted a comment from github-actions bot May 22, 2024
@vzarytovskii vzarytovskii changed the title .NET 9preview4 .NET 9preview5 Jun 18, 2024
@ViktorHofer
Copy link
Member

@vzarytovskii just curious, will you also update to Arcade 9 soon? That would allow us to clean-up a bit of infra here.

@vzarytovskii
Copy link
Member Author

@vzarytovskii just curious, will you also update to Arcade 9 soon? That would allow us to clean-up a bit of infra here.

Yup, once we done with p5 upgrade, I will be moving us to net9 by default + consuming arcade and dotnet-optimization from the NET9 channels

@psfinaki psfinaki enabled auto-merge (squash) June 25, 2024 15:28
@psfinaki
Copy link
Contributor

@dotnet/source-build-internal please take a look.

@psfinaki psfinaki requested a review from MichaelSimons June 27, 2024 11:35
@ViktorHofer
Copy link
Member

Source-build changes LGTM

@ViktorHofer
Copy link
Member

@MichaelSimons / @mthalman can you please approve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants