expected ↔ actual
#17014
Merged
expected ↔ actual
#17014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ No release notes required |
abonie
approved these changes
Apr 10, 2024
T-Gro
approved these changes
Apr 10, 2024
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
expectedandactualarguments swapped in their assertions. This made it very confusing when they failed as I was working on Better integral range lowering:start..finish,start..step..finish#16650. I didn't want to correct them in that PR since I didn't want to make the diff bigger than needed. There may be other assertions in this file that should also have their arguments swapped (and there are certainly others in this repo where that is the case); I am only updating the integral-range-related tests here.