Skip to content

Conversation

@nojaf
Copy link
Contributor

@nojaf nojaf commented Mar 14, 2024

Description

Right now -v enables the logger in FsYacc driver and creates a pars.fsyacc.output file of about 32 MB in size.

See https://github.com/fsprojects/FsLexYacc/blob/f7a960fbd962325ce115986b843c3f23a0d72877/src/FsYacc/fsyacc.fs#L30

I don't think this is useful to generate by default and I want to turn it off.
Compiler.fsproj compiles about 8 seconds after on my local machine with this thing turned off.

drops the mic

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@nojaf nojaf requested a review from a team as a code owner March 14, 2024 13:54
@nojaf nojaf added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Mar 14, 2024
@github-actions
Copy link
Contributor

Caution

Repository is on lockdown for maintenance, all merges are on hold.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2024

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@auduchinok
Copy link
Member

Compiler.fsproj compiles about 8 seconds after on my local machine with this thing turned off.

What was the time with it on?

@nojaf
Copy link
Contributor Author

nojaf commented Mar 14, 2024

image

Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vzarytovskii
Copy link
Member

That's nice! Hopefully we'll be able to shave off even more with caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants