Skip to content

Revert "Allow access modifiers to auto properties getters and setters (#16687)" #16831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2024
Merged

Revert "Allow access modifiers to auto properties getters and setters (#16687)" #16831

merged 1 commit into from
Mar 7, 2024

Conversation

@psfinaki
Copy link
Contributor

@psfinaki psfinaki commented Mar 7, 2024

This reverts commit c4f7bed:

  • was merged accidentally while repo maintenance, causing issues now
  • also see this comment - we should fix a few things here

@psfinaki psfinaki requested a review from a team as a code owner March 7, 2024 17:19
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Caution

Repository is on lockdown for maintenance, all merges are on hold.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@abonie abonie added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Mar 7, 2024
@KevinRansom KevinRansom merged commit 31f3d2b into dotnet:main Mar 7, 2024
@dotnet-bot dotnet-bot mentioned this pull request Mar 12, 2024
Closed
@psfinaki psfinaki deleted the revert branch February 10, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonie abonie abonie approved these changes

+1 more reviewer

@KevinRansom KevinRansom KevinRansom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@psfinaki @KevinRansom @abonie