-
Notifications
You must be signed in to change notification settings - Fork 832
Let TransparentCompiler respect hash directives like #nowarn #16667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8c3a046
use file-specific DiagnosticOptions in ComputeParseAndCheckProject to…
dawedawe bf44b30
Merge branch 'main' into transcomp_filespecificdiagopts
dawedawe 33b20ae
filter diagnostics to the name of the given file and handle diagnosti…
dawedawe ea63e44
Merge branch 'main' into transcomp_filespecificdiagopts
dawedawe e62c29d
shuffle the loggers and scopes in ComputeTcIntermediate to respect th…
dawedawe c5eb1bc
add test for transparent compiler respecting nowarn hash directives
dawedawe 0b135a6
bring in changes from b47ba47
dawedawe a949af0
Don't promote informational diagnostics too liberally to Warnings
dawedawe fccd88b
Revert "bring in changes from b47ba47"
dawedawe a497155
Merge branch 'main' into transcomp_filespecificdiagopts
dawedawe 2bec620
extend test to show that old behaviour of DiagnosticsLoggerFilteringB…
dawedawe 76dd9bc
revert to old and correct severity handling
dawedawe 9dcdbb1
use `compile` instead of typecheck to let the severity propagation ha…
dawedawe ebb1b9e
no need to test informational warnings anymore
dawedawe 1eaf5d3
adjust quotation test, too.
dawedawe 77e3b4f
Merge branch 'main' into transcomp_filespecificdiagopts
dawedawe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.