Skip to content

Conversation

@dotnet-bot
Copy link
Contributor

This is an automatically generated pull request from main into release/net8.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/main-to-release/net8
git reset --hard upstream/release/net8
git merge upstream/main
# Fix merge conflicts
git commit
git push upstream merges/main-to-release/net8 --force

oleksandr-didyk and others added 4 commits June 2, 2023 09:39
* add review comment to sb files

* add CODEOWNERS entry for source-build
* Proof of concept

* Add generic parameter names to ModuleOrType.

* Revert ModuleOrType change

* Process ticks in demangledPath of TType_app.

* Only apply new logic when includeStaticParametersInTypeNames is active.

* Use FactForNETCOREAPP

* Fix build

---------

Co-authored-by: Tomas Grosup <[email protected]>
* Improve implied lambda and delegate argument names

* Fix

* Add tests

* Revert non-preview tests

* Sigh

* Re-revert

* Fix test

* Add testx
@T-Gro T-Gro merged commit 9b2f911 into release/net8 Jun 6, 2023
@T-Gro T-Gro deleted the merges/main-to-release/net8 branch June 6, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants