Faster finding references

src/Compiler/Checking/CheckDeclarations.fs

@@ -5290,7 +5290,7 @@ let CheckOneImplFile
         rootSigOpt: ModuleOrNamespaceType option,
         synImplFile) =
 
-    let (ParsedImplFileInput (_, isScript, qualNameOfFile, scopedPragmas, _, implFileFrags, isLastCompiland, _)) = synImplFile
+    let (ParsedImplFileInput (_, isScript, qualNameOfFile, scopedPragmas, _, implFileFrags, isLastCompiland, _, _)) = synImplFile
     let infoReader = InfoReader(g, amap)
 
     cancellable {

src/Compiler/Driver/ParseAndCheckInputs.fs

@@ -92,13 +92,13 @@ let PrependPathToSpec x (SynModuleOrNamespaceSig (longId, isRecursive, kind, dec
 
 let PrependPathToInput x inp =
     match inp with
-    | ParsedInput.ImplFile (ParsedImplFileInput (b, c, q, d, hd, impls, e, trivia)) ->
+    | ParsedInput.ImplFile (ParsedImplFileInput (b, c, q, d, hd, impls, e, trivia, i)) ->
         ParsedInput.ImplFile(
-            ParsedImplFileInput(b, c, PrependPathToQualFileName x q, d, hd, List.map (PrependPathToImpl x) impls, e, trivia)
+            ParsedImplFileInput(b, c, PrependPathToQualFileName x q, d, hd, List.map (PrependPathToImpl x) impls, e, trivia, i)
         )
 
-    | ParsedInput.SigFile (ParsedSigFileInput (b, q, d, hd, specs, trivia)) ->
-        ParsedInput.SigFile(ParsedSigFileInput(b, PrependPathToQualFileName x q, d, hd, List.map (PrependPathToSpec x) specs, trivia))
+    | ParsedInput.SigFile (ParsedSigFileInput (b, q, d, hd, specs, trivia, i)) ->
+        ParsedInput.SigFile(ParsedSigFileInput(b, PrependPathToQualFileName x q, d, hd, List.map (PrependPathToSpec x) specs, trivia, i))
 
 let IsValidAnonModuleName (modname: string) =
     modname |> String.forall (fun c -> Char.IsLetterOrDigit c || c = '_')
@@ -243,7 +243,8 @@ let PostParseModuleImpls
         isLastCompiland,
         ParsedImplFile (hashDirectives, impls),
         lexbuf: UnicodeLexing.Lexbuf,
-        tripleSlashComments: range list
+        tripleSlashComments: range list,
+        identifiers: Set<string>
     ) =
     let othersWithSameName =
         impls
@@ -283,7 +284,9 @@ let PostParseModuleImpls
             CodeComments = codeComments
         }
 
-    ParsedInput.ImplFile(ParsedImplFileInput(fileName, isScript, qualName, scopedPragmas, hashDirectives, impls, isLastCompiland, trivia))
+    ParsedInput.ImplFile(
+        ParsedImplFileInput(fileName, isScript, qualName, scopedPragmas, hashDirectives, impls, isLastCompiland, trivia, identifiers)
+    )
 
 let PostParseModuleSpecs
     (
@@ -292,7 +295,8 @@ let PostParseModuleSpecs
         isLastCompiland,
         ParsedSigFile (hashDirectives, specs),
         lexbuf: UnicodeLexing.Lexbuf,
-        tripleSlashComments: range list
+        tripleSlashComments: range list,
+        identifiers: Set<string>
     ) =
     let othersWithSameName =
         specs
@@ -331,7 +335,7 @@ let PostParseModuleSpecs
             CodeComments = codeComments
         }
 
-    ParsedInput.SigFile(ParsedSigFileInput(fileName, qualName, scopedPragmas, hashDirectives, specs, trivia))
+    ParsedInput.SigFile(ParsedSigFileInput(fileName, qualName, scopedPragmas, hashDirectives, specs, trivia, identifiers))
 
 type ModuleNamesDict = Map<string, Map<string, QualifiedNameOfFile>>
 
@@ -376,26 +380,26 @@ let DeduplicateModuleName (moduleNamesDict: ModuleNamesDict) fileName (qualNameO
 let DeduplicateParsedInputModuleName (moduleNamesDict: ModuleNamesDict) input =
     match input with
     | ParsedInput.ImplFile implFile ->
-        let (ParsedImplFileInput (fileName, isScript, qualNameOfFile, scopedPragmas, hashDirectives, modules, flags, trivia)) =
+        let (ParsedImplFileInput (fileName, isScript, qualNameOfFile, scopedPragmas, hashDirectives, modules, flags, trivia, identifiers)) =
             implFile
 
         let qualNameOfFileR, moduleNamesDictR =
             DeduplicateModuleName moduleNamesDict fileName qualNameOfFile
 
         let implFileR =
-            ParsedImplFileInput(fileName, isScript, qualNameOfFileR, scopedPragmas, hashDirectives, modules, flags, trivia)
+            ParsedImplFileInput(fileName, isScript, qualNameOfFileR, scopedPragmas, hashDirectives, modules, flags, trivia, identifiers)
 
         let inputR = ParsedInput.ImplFile implFileR
         inputR, moduleNamesDictR
     | ParsedInput.SigFile sigFile ->
-        let (ParsedSigFileInput (fileName, qualNameOfFile, scopedPragmas, hashDirectives, modules, trivia)) =
+        let (ParsedSigFileInput (fileName, qualNameOfFile, scopedPragmas, hashDirectives, modules, trivia, identifiers)) =
             sigFile
 
         let qualNameOfFileR, moduleNamesDictR =
             DeduplicateModuleName moduleNamesDict fileName qualNameOfFile
 
         let sigFileR =
-            ParsedSigFileInput(fileName, qualNameOfFileR, scopedPragmas, hashDirectives, modules, trivia)
+            ParsedSigFileInput(fileName, qualNameOfFileR, scopedPragmas, hashDirectives, modules, trivia, identifiers)
 
         let inputT = ParsedInput.SigFile sigFileR
         inputT, moduleNamesDictR
@@ -426,6 +430,17 @@ let ParseInput
 
     try
         let input =
+            let identStore = HashSet<string>()
+
+            let identCaptureLexer x =
+                let token = lexer x
+
+                match token with
+                | Parser.token.IDENT ident -> identStore.Add ident |> ignore
+                | _ -> ()
+
+                token
+
             if FSharpMLCompatFileSuffixes |> List.exists (FileSystemUtils.checkSuffix fileName) then
                 if lexbuf.SupportsFeature LanguageFeature.MLCompatRevisions then
                     errorR (Error(FSComp.SR.buildInvalidSourceFileExtensionML fileName, rangeStartup))
@@ -434,19 +449,19 @@ let ParseInput
 
             // Call the appropriate parser - for signature files or implementation files
             if FSharpImplFileSuffixes |> List.exists (FileSystemUtils.checkSuffix fileName) then
-                let impl = Parser.implementationFile lexer lexbuf
+                let impl = Parser.implementationFile identCaptureLexer lexbuf
 
                 let tripleSlashComments =
                     LexbufLocalXmlDocStore.ReportInvalidXmlDocPositions(lexbuf)
 
-                PostParseModuleImpls(defaultNamespace, fileName, isLastCompiland, impl, lexbuf, tripleSlashComments)
+                PostParseModuleImpls(defaultNamespace, fileName, isLastCompiland, impl, lexbuf, tripleSlashComments, Set identStore)
             elif FSharpSigFileSuffixes |> List.exists (FileSystemUtils.checkSuffix fileName) then
-                let intfs = Parser.signatureFile lexer lexbuf
+                let intfs = Parser.signatureFile identCaptureLexer lexbuf
 
                 let tripleSlashComments =
                     LexbufLocalXmlDocStore.ReportInvalidXmlDocPositions(lexbuf)
 
-                PostParseModuleSpecs(defaultNamespace, fileName, isLastCompiland, intfs, lexbuf, tripleSlashComments)
+                PostParseModuleSpecs(defaultNamespace, fileName, isLastCompiland, intfs, lexbuf, tripleSlashComments, Set identStore)
             else if lexbuf.SupportsFeature LanguageFeature.MLCompatRevisions then
                 error (Error(FSComp.SR.buildInvalidSourceFileExtensionUpdated fileName, rangeStartup))
             else
@@ -518,7 +533,8 @@ let EmptyParsedInput (fileName, isLastCompiland) =
                 {
                     ConditionalDirectives = []
                     CodeComments = []
-                }
+                },
+                Set.empty
             )
         )
     else
@@ -534,7 +550,8 @@ let EmptyParsedInput (fileName, isLastCompiland) =
                 {
                     ConditionalDirectives = []
                     CodeComments = []
-                }
+                },
+                Set.empty
             )
         )
 

src/Compiler/Driver/ScriptClosure.fs

@@ -515,13 +515,23 @@ module ScriptPreprocessClosure =
         match lastParsedInput with
         | Some (ParsedInput.ImplFile lastParsedImplFile) ->
 
-            let (ParsedImplFileInput (name, isScript, qualNameOfFile, scopedPragmas, hashDirectives, implFileFlags, _, trivia)) =
+            let (ParsedImplFileInput (name, isScript, qualNameOfFile, scopedPragmas, hashDirectives, implFileFlags, _, trivia, identifiers)) =
                 lastParsedImplFile
 
             let isLastCompiland = (true, tcConfig.target.IsExe)
 
             let lastParsedImplFileR =
-                ParsedImplFileInput(name, isScript, qualNameOfFile, scopedPragmas, hashDirectives, implFileFlags, isLastCompiland, trivia)
+                ParsedImplFileInput(
+                    name,
+                    isScript,
+                    qualNameOfFile,
+                    scopedPragmas,
+                    hashDirectives,
+                    implFileFlags,
+                    isLastCompiland,
+                    trivia,
+                    identifiers
+                )
 
             let lastClosureFileR =
                 ClosureFile(fileName, m, Some(ParsedInput.ImplFile lastParsedImplFileR), parseDiagnostics, metaDiagnostics, nowarns)

src/Compiler/Interactive/fsi.fs

@@ -1850,7 +1850,7 @@ type internal FsiDynamicCompiler(
         let impl = SynModuleOrNamespace(prefix,false, SynModuleOrNamespaceKind.NamedModule,defs,PreXmlDoc.Empty,[],None,m, { LeadingKeyword = SynModuleOrNamespaceLeadingKeyword.None })
         let isLastCompiland = true
         let isExe = false
-        let input = ParsedInput.ImplFile (ParsedImplFileInput (fileName,true, ComputeQualifiedNameOfFileFromUniquePath (m,prefixPath),[],[],[impl],(isLastCompiland, isExe), { ConditionalDirectives = []; CodeComments = [] }))
+        let input = ParsedInput.ImplFile (ParsedImplFileInput (fileName,true, ComputeQualifiedNameOfFileFromUniquePath (m,prefixPath),[],[],[impl],(isLastCompiland, isExe), { ConditionalDirectives = []; CodeComments = [] }, Set.empty))
         let isIncrementalFragment = true
         let istate,tcEnvAtEndOfLastInput,declaredImpls = ProcessInputs (ctok, diagnosticsLogger, istate, [input], showTypes, isIncrementalFragment, isInteractiveItExpr, prefix, m)
         let tcState = istate.tcState

src/Compiler/Service/IncrementalBuild.fs

@@ -134,7 +134,8 @@ module IncrementalBuildSyntaxTree =
                                 [],
                                 [],
                                 isLastCompiland,
-                                { ConditionalDirectives = []; CodeComments = [] }
+                                { ConditionalDirectives = []; CodeComments = [] },
+                                Set.empty
                             )
                         )
                     else
@@ -284,7 +285,8 @@ type BoundModel private (tcConfig: TcConfig,
                 GraphNode(node {
                     match! this.TypeCheck(false) with
                     | FullState(tcInfo, tcInfoExtras) -> return tcInfo, tcInfoExtras
-                    | PartialState(tcInfo) -> return tcInfo, emptyTcInfoExtras
+                    | PartialState(tcInfo) -> 
+                        return tcInfo, emptyTcInfoExtras
                 })
 
             let partialGraphNode =              

src/Compiler/Service/SemanticClassificationKey.fs

@@ -56,8 +56,13 @@ type SemanticClassificationKeyStoreBuilder() =
     let b = BlobBuilder()
 
     member _.WriteAll(semanticClassification: SemanticClassificationItem[]) =
-        use ptr = fixed semanticClassification
-        b.WriteBytes(NativePtr.ofNativeInt (NativePtr.toNativeInt ptr), semanticClassification.Length * sizeof<SemanticClassificationItem>)
+        if semanticClassification.Length > 0 then
+            use ptr = fixed semanticClassification
+
+            b.WriteBytes(
+                NativePtr.ofNativeInt (NativePtr.toNativeInt ptr),
+                semanticClassification.Length * sizeof<SemanticClassificationItem>
+            )
 
     member _.TryBuildAndReset() =
         if b.Count > 0 then

src/Compiler/Service/service.fs

@@ -1362,7 +1362,14 @@ type FSharpChecker
         let canInvalidateProject = defaultArg canInvalidateProject true
         let userOpName = defaultArg userOpName "Unknown"
 
-        backgroundCompiler.FindReferencesInFile(fileName, options, symbol, canInvalidateProject, userOpName)
+        node {
+            let! parseResults = backgroundCompiler.GetBackgroundParseResultsForFileInProject(fileName, options, userOpName)
+
+            if parseResults.ParseTree.Identifiers |> Set.contains symbol.DisplayName then
+                return! backgroundCompiler.FindReferencesInFile(fileName, options, symbol, canInvalidateProject, userOpName)
+            else
+                return Seq.empty
+        }
         |> Async.AwaitNodeCode
 
     member _.GetBackgroundSemanticClassificationForFile(fileName: string, options: FSharpProjectOptions, ?userOpName) =

src/Compiler/SyntaxTree/SyntaxTree.fs

@@ -1680,7 +1680,8 @@ type ParsedImplFileInput =
         hashDirectives: ParsedHashDirective list *
         contents: SynModuleOrNamespace list *
         flags: (bool * bool) *
-        trivia: ParsedImplFileInputTrivia
+        trivia: ParsedImplFileInputTrivia *
+        identifiers: Set<string>
 
     member x.QualifiedName =
         (let (ParsedImplFileInput (qualifiedNameOfFile = qualNameOfFile)) = x in qualNameOfFile)
@@ -1712,7 +1713,8 @@ type ParsedSigFileInput =
         scopedPragmas: ScopedPragma list *
         hashDirectives: ParsedHashDirective list *
         contents: SynModuleOrNamespaceSig list *
-        trivia: ParsedSigFileInputTrivia
+        trivia: ParsedSigFileInputTrivia *
+        identifiers: Set<string>
 
     member x.QualifiedName =
         (let (ParsedSigFileInput (qualifiedNameOfFile = qualNameOfFile)) = x in qualNameOfFile)
@@ -1755,3 +1757,8 @@ type ParsedInput =
         | ParsedInput.ImplFile (ParsedImplFileInput(contents = SynModuleOrNamespace (range = m) :: _))
         | ParsedInput.SigFile (ParsedSigFileInput(contents = SynModuleOrNamespaceSig (range = m) :: _)) -> m
         | _ -> rangeN inp.FileName 0
+
+    member inp.Identifiers =
+        match inp with
+        | ParsedInput.ImplFile (ParsedImplFileInput (identifiers = identifiers))
+        | ParsedInput.SigFile (ParsedSigFileInput (identifiers = identifiers)) -> identifiers

src/Compiler/SyntaxTree/SyntaxTree.fsi

@@ -1889,7 +1889,8 @@ type ParsedImplFileInput =
         hashDirectives: ParsedHashDirective list *
         contents: SynModuleOrNamespace list *
         flags: (bool * bool) *
-        trivia: ParsedImplFileInputTrivia
+        trivia: ParsedImplFileInputTrivia *
+        identifiers: Set<string>
 
     member FileName: string
 
@@ -1918,7 +1919,8 @@ type ParsedSigFileInput =
         scopedPragmas: ScopedPragma list *
         hashDirectives: ParsedHashDirective list *
         contents: SynModuleOrNamespaceSig list *
-        trivia: ParsedSigFileInputTrivia
+        trivia: ParsedSigFileInputTrivia *
+        identifiers: Set<string>
 
     member FileName: string
 
@@ -1952,3 +1954,6 @@ type ParsedInput =
 
     /// Gets the #nowarn and other scoped pragmas
     member ScopedPragmas: ScopedPragma list
+
+    /// Gets a set of all identifiers used in this parsed input
+    member Identifiers: Set<string>

tests/FSharp.Compiler.ComponentTests/FSharpChecker/SymbolUse.fs

@@ -76,4 +76,28 @@ val f: x: 'a -> TFirstV_1<'a>
             checkFile "First" (fun (typeCheckResult: FSharpCheckFileResults) ->
                 let symbolUse = typeCheckResult.GetSymbolUseAtLocation(6, 14, "let private f3 x = x + 1", ["f3"]) |> Option.defaultWith (fun () -> failwith "no symbol use found")
                 Assert.False(symbolUse.IsPrivateToFile))
+        }
+
+module FindReferences =
+
+
+    [<Fact>]
+    let ``Finding references in project`` () =
+        let size = 20
+
+        let project =
+            { SyntheticProject.Create() with
+                SourceFiles = [
+                    sourceFile $"File%03d{0}" [] |> addSignatureFile
+                    for i in 1..size do
+                        sourceFile $"File%03d{i}" [$"File%03d{i-1}"]
+                ]
+            }
+            |> updateFile "File005" (addDependency "File000")
+            |> updateFile "File010" (addDependency "File000")
+
+        let checker = FSharpChecker.Create(enableBackgroundItemKeyStoreAndSemanticClassification = true)
+
+        project.WorkflowWith checker {
+            findAllReferencesToModuleFromFile "File000" (expectNumberOfResults 5)
         }