Skip to content

Print attributes of nested modules in signatures. #13890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Print attributes of nested modules in signatures. #13890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
739049f
Print attributes of nested modules in signatures.
nojaf Sep 13, 2022
7e13501
Merge branch 'main' into signature-attributes-on-nested-modules
dsyme Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Compiler/Checking/NicePrint.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2387,7 +2387,9 @@ module InferredSigPrinting =
let nmL = layoutAccessibility denv mspec.Accessibility nmL
let denv = denv.AddAccessibility mspec.Accessibility
let basic = imdefL denv def
let modNameL = wordL (tagKeyword "module") ^^ nmL
let modNameL =
wordL (tagKeyword "module") ^^ nmL
|> layoutAttribs denv None false mspec.TypeOrMeasureKind mspec.Attribs
let modNameEqualsL = modNameL ^^ WordL.equals
let isNamespace = function | Namespace _ -> true | _ -> false
let modIsOuter = (outerPath |> List.forall (fun (_, istype) -> isNamespace istype) )
Expand Down
22 changes: 22 additions & 0 deletions tests/FSharp.Compiler.ComponentTests/Signatures/ModuleOrNamespaceTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,3 +197,25 @@ do ()
"""
|> printSignatures
|> should equal "namespace Foobar"

[<Fact>]
let ``Attribute on nested module`` () =
FSharp
"""
namespace MyApp.Types

[<RequireQualifiedAccess>]
[<CompilationRepresentation(CompilationRepresentationFlags.ModuleSuffix)>]
module Area =
type Meh = class end
"""
|> printSignatures
|> prependNewline
|> should equal """
namespace MyApp.Types

[<RequireQualifiedAccess; CompilationRepresentation (enum<CompilationRepresentationFlags> (4))>]
module Area =

type Meh =
class end"""