Introduce ConditionalDirectiveTrivia. #12843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
reviewed
Mar 14, 2022
nojaf
force-pushed
the
conditional-directives
branch
from
95046fc to
caab632
Compare
nojaf
commented
Mar 15, 2022
|
@dsyme this is ready for review. I think I covered all cases. |
dsyme
requested changes
Mar 17, 2022
dsyme
reviewed
Mar 17, 2022
dsyme
approved these changes
Mar 18, 2022
|
Great work! |
|
Thanks, this really simplifies so many things on Fantomas' side 🤗. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt to fix #12815.
@dsyme would you mind reviewing this, please? To get an idea if am I heading in the right direction with this.