-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use net6 previews for building #11545
Conversation
Should be good after #11530 gets merged, since it has introduced searching for suffixed dotnet SDKs. |
Seems it's picking up a wrong global.json. Going to look at it tomorrow morning.
|
…e multilevel lookup of global.json files.
According to microsoft/azure-pipelines-tasks#11840, |
…nstead of global.json.
…5.0 everywhere. Changed generated appsettings to use net6.0.
Getting some weird issue when running some of the cambridge single-test suites;
However, whan I run the target manually, it seems to be working ok:
@KevinRansom @brettfo does this ring a bell? |
Okay, |
dotnet/runtime#54656 gonna end up in preview7, so this is blocked for now from merging, gonna update and see if it's building and running tests fine. |
After talking to @KevinRansom and @brettfo disabling failing test as agreed, going to re-enable after preview7 is released. |
…t is broken till preview7 gets released
@KevinRansom @brettfo We can merge it now (fsi array tests are disabled, going to re-enable once preview7 is released). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, why the deleted span tests?
These were testing a regression, which got fixed with net6. On a second thought I probably should just change the assert. |
@vzarytovskii What is the reason to require the SDK preview for building FSharp.Compiler.Service.sln? It makes things much worse for external contributors. |
We use sdk Arcade uses by default, which will allow us to test latest runtime/sdk faster and see if there were any regressions (we were hitting some earlier this year). It is a fair point though, I'm not sure how can we support more than one SDK. |
We can move the FCS solution back to a separate folder and have a separate global.json there. |
Yeah, I guess that would work, it bothers me slightly though - that we'll essentially use two different SDKS. What SDK do you think should be used for the service? |
I'd say the oldest suitable for building the solution (including on the CI) or the previously used one, 5.0.300. |
Huh, I don't think we build service solution in CI (at least, not directly via build scripts, or in yml), probably should add those too. |
Created #11933 for tracking it. |
That would be really great if it's indeed not being built currently! 🙂 |
No description provided.