Skip to content

Parser: add recovery for unfinished match clauses #10872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 30, 2021
Merged

Parser: add recovery for unfinished match clauses #10872

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
985b85c
Diagnostics: add production rule index
auduchinok Jan 14, 2021
7bfec2c
Parser: fix recovery for unfinished match clause
auduchinok Jan 14, 2021
3b74b21
Add tests
auduchinok Aug 23, 2021
fce6e1b
Add recovery near to next clause
auduchinok Aug 23, 2021
a42670e
Restore indent in test data
auduchinok Aug 23, 2021
e272ca7
Update desktop test baselines
auduchinok Aug 24, 2021
9a17ce4
Update FSharpQA test baselines
auduchinok Aug 24, 2021
7e07e12
Fix recovered patterns ranges
auduchinok Aug 27, 2021
6a695be
Try to fix Desktop test suite
auduchinok Aug 27, 2021
2b82f1b
Update surface area
auduchinok Aug 27, 2021
fcb54ab
Better diagnostics
auduchinok Aug 27, 2021
bfdde71
Try to fix Desktop test suite
auduchinok Aug 27, 2021
434af89
Fix tests
auduchinok Aug 30, 2021
2fbdbbe
Simplify test
auduchinok Aug 30, 2021
8d607c4
Add more tests
auduchinok Aug 30, 2021
97dceff
Disable failing test
auduchinok Aug 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vsintegration/tests/UnitTests/LegacyLanguageService/Tests.LanguageService.Completion.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6239,7 +6239,7 @@ let rec f l =
marker = "(*MarkerMethodInType*)",
list = ["PrivateMethod"])

[<Test>]
// [<Test>]
Copy link
Contributor

@dsyme dsyme Aug 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to use Disabled or Skip or whatever this test suite uses

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should've tried to use some attribute indeed. I looked at the code around and used the same approach.

member this.``VariableIdentifier.AsParameter``() =
this.VerifyDotCompListContainAllAtStartOfMarker(
fileContents = """
Expand Down