-
Notifications
You must be signed in to change notification settings - Fork 889
Fix SqliteVectorStoreWriterTests hang: reduce test record count and use conditional MaxTopCount #7360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix SqliteVectorStoreWriterTests hang: reduce test record count and use conditional MaxTopCount #7360
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
523a9b1
Initial plan
Copilot 0389ba7
Fix SqliteVectorStoreWriterTests hang: reduce test records from 2500 …
Copilot f706837
Rename seenKeys to keys per code review feedback
Copilot 8f3c419
Revert production code change; keep only the test fix (reduce 2500 to…
Copilot ddca4cd
Use conditional compilation for MaxTopCount per review feedback
Copilot d7a02cf
Apply suggestions from code review
adamsitnik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.