Skip to content

Fix flaky HttpRequestBuffering_DoesNotBufferDisabledOrOversizedLogs test #7304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 3 commits into from
Feb 24, 2026
Merged

Fix flaky HttpRequestBuffering_DoesNotBufferDisabledOrOversizedLogs test #7304

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3db2c52
Initial plan
Copilot Feb 14, 2026
f8a9618
Fix flaky test HttpRequestBuffering_DoesNotBufferDisabledOrOversizedL…
Copilot Feb 14, 2026
010b0ad
Fix comment to correctly describe log emission order
Copilot Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions test/Libraries/Microsoft.AspNetCore.Diagnostics.Middleware.Tests/Logging/AcceptanceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,14 +900,10 @@ await RunAsync<TestStartup>(
services => services
.AddLogging(builder =>
{
// enable Microsoft.AspNetCore.Routing.Matching.DfaMatcher debug logs
// which are produced by ASP.NET Core within HTTP context.
// This is what is going to be buffered and tested.
builder.AddFilter("Microsoft.AspNetCore.Routing.Matching.DfaMatcher", LogLevel.Debug);

// Disable logs from HTTP logging middleware, otherwise even though they are not buffered,
// they will be logged as usual and contaminate test results:
builder.AddFilter("Microsoft.AspNetCore.HttpLogging", LogLevel.None);
// Disable logs from all ASP.NET Core infrastructure, otherwise they
// will contaminate test results:
builder.AddFilter("Microsoft.AspNetCore", LogLevel.None);
builder.AddFilter("Microsoft.AspNetCore.HttpLogging.HttpLoggingMiddleware", LogLevel.None);

builder.AddPerIncomingRequestBuffer(options =>
{
Expand Down Expand Up @@ -944,10 +940,10 @@ await RunAsync<TestStartup>(
logger.LogTrace($"This is a huge log message 3, {hugeState}");
await WaitForLogRecordsAsync(logCollector, _defaultLogTimeout);

// 1st log record is from DfaMatcher,
// 2, 3, 4th are from our "test" category
// and 5 and 6th are logs from the /logatrequest endpoint
Assert.Equal(6, logCollector.Count);
// 1st is the flushed Trace from "test" category
// 2, 3rd are unbuffered logs from our "test" category
// and 4 and 5th are logs from the /logatrequest endpoint
Comment thread
stephentoub marked this conversation as resolved.
Outdated
Assert.Equal(5, logCollector.Count);
Assert.Equal(LogLevel.Trace, logCollector.LatestRecord.Level);
Assert.Equal("test", logCollector.LatestRecord.Category);
});
Expand Down
Loading