-
Notifications
You must be signed in to change notification settings - Fork 849
Remove unnecessary description tags #7226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Are these also unnecessary for VS / IntelliSense consuming these XML docs from nuget packages? |
src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionFactory.cs
Show resolved
Hide resolved
Yes, it was just a bug in Learn that the bullets only rendered with description tags. For longer story, see dotnet/roslyn#81895. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request removes unnecessary <description> tags from XML documentation comments within bullet list <item> elements, following a bug fix in the Microsoft Learn platform that no longer requires these tags.
Changes:
- Updated XML documentation in Telemetry Abstractions libraries (metrics attributes, logging attributes, HTTP metadata)
- Updated XML documentation in Resilience library (service collection extensions)
- Updated XML documentation in AI Abstractions library (function factory methods)
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Libraries/Microsoft.Extensions.Telemetry.Abstractions/Metrics/HistogramAttributeT.cs | Removed <description> tags from 5 bullet items describing method constraints |
| src/Libraries/Microsoft.Extensions.Telemetry.Abstractions/Metrics/HistogramAttribute.cs | Removed <description> tags from 5 bullet items describing method constraints |
| src/Libraries/Microsoft.Extensions.Telemetry.Abstractions/Metrics/GaugeAttribute.cs | Removed <description> tags from 5 bullet items describing method constraints |
| src/Libraries/Microsoft.Extensions.Telemetry.Abstractions/Metrics/CounterAttributeT.cs | Removed <description> tags from 5 bullet items describing method constraints |
| src/Libraries/Microsoft.Extensions.Telemetry.Abstractions/Metrics/CounterAttribute.cs | Removed <description> tags from 5 bullet items describing method constraints |
| src/Libraries/Microsoft.Extensions.Telemetry.Abstractions/Logging/TagProviderAttribute.cs | Removed <description> tags from 2 bullet items describing method parameter requirements |
| src/Libraries/Microsoft.Extensions.Telemetry.Abstractions/Http/RequestMetadata.cs | Removed <description> tags from multiple bullet items across 3 property documentation sections |
| src/Libraries/Microsoft.Extensions.Resilience/Resilience/ResilienceServiceCollectionExtensions.cs | Removed <description> tags from 2 bullet items describing enrichment features |
| src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionFactory.cs | Removed <description> tags from bullet items across 5 method overloads documenting parameter binding behavior |
Learn platform fixed a bug such that <description> tags within bullet list <item> elements are no longer necessary. See https://ceapex.visualstudio.com/Engineering/_workitems/edit/1122283/.
Microsoft Reviewers: Open in CodeFlow