-
Notifications
You must be signed in to change notification settings - Fork 849
Add Ordinal into ordering #7225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fall out from dotnet/runtime#123428 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds explicit StringComparer.Ordinal to all OrderBy operations in the ComplianceReports generator's Emitter.cs file, following up on a discussion in a related runtime PR. This ensures culture-invariant, deterministic ordering for generated compliance reports.
Changes:
- Added
StringComparer.Ordinalparameter to 5OrderByoperations for sorting types, members, classifications, logging methods, and parameters
|
CC @geeknoid |
tarekgh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cincuranet!
Fall out from dotnet/runtime#123428 (comment).
Microsoft Reviewers: Open in CodeFlow