Skip to content

Conversation

@cincuranet
Copy link
Contributor

@cincuranet cincuranet commented Jan 22, 2026

Fall out from dotnet/runtime#123428 (comment).

Microsoft Reviewers: Open in CodeFlow

@cincuranet cincuranet requested a review from tarekgh January 22, 2026 13:37
@cincuranet cincuranet marked this pull request as ready for review January 22, 2026 13:37
@cincuranet cincuranet requested a review from a team as a code owner January 22, 2026 13:37
Copilot AI review requested due to automatic review settings January 22, 2026 13:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds explicit StringComparer.Ordinal to all OrderBy operations in the ComplianceReports generator's Emitter.cs file, following up on a discussion in a related runtime PR. This ensures culture-invariant, deterministic ordering for generated compliance reports.

Changes:

  • Added StringComparer.Ordinal parameter to 5 OrderBy operations for sorting types, members, classifications, logging methods, and parameters

@tarekgh
Copy link
Member

tarekgh commented Jan 22, 2026

CC @geeknoid

Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cincuranet!

@cincuranet cincuranet merged commit d746d0d into main Jan 23, 2026
12 of 13 checks passed
@cincuranet cincuranet deleted the explicit-comparer branch January 23, 2026 07:04
This was referenced Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants