Fix CS0757 error when multi-targeting with Microsoft.Extensions.Telemetry.Abstractions #7062
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
stephentoub marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <!-- This package should replace the Microsoft.Extensions.Logging.Abstractions source generator, so we set the property to remove the source generator from the project. --> | ||
| <PropertyGroup> | ||
| <DisableMicrosoftExtensionsLoggingSourceGenerator>true</DisableMicrosoftExtensionsLoggingSourceGenerator> | ||
| </PropertyGroup> | ||
| </Project> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| <Project> | ||
| <!-- This package should replace the "Microsoft.Extensions.Logging.Abstractions" source generator. --> | ||
| <Target Name="_Microsoft_Extensions_Telemetry_AbstractionsRemoveAnalyzers" | ||
|
Member
There was a problem hiding this comment. Can you help me understand why this new net9 folder is needed? the way buildTransitive folder works, should make it such that if a net9 folder is not present but the app targets net9, it should just fallback and import the files from net8. |
||
| Condition="'$(DisableMicrosoftExtensionsLoggingSourceGenerator)' == 'true'" | ||
| AfterTargets="ResolveReferences"> | ||
| <ItemGroup> | ||
| <_Microsoft_Extensions_Logging_AbstractionsAnalyzer | ||
| Include="@(Analyzer)" | ||
| Condition="'%(Analyzer.AssemblyName)' == 'Microsoft.Extensions.Logging.Generators' Or | ||
| '%(Analyzer.NuGetPackageId)' == 'Microsoft.Extensions.Logging.Abstractions'" /> | ||
| </ItemGroup> | ||
|
|
||
| <!-- Remove Microsoft.Extensions.Logging.Abstractions Analyzer --> | ||
| <ItemGroup> | ||
| <Analyzer Remove="@(_Microsoft_Extensions_Logging_AbstractionsAnalyzer)" /> | ||
| </ItemGroup> | ||
| </Target> | ||
|
|
||
| <!-- We have a WPF-specific target because WPF projects generate and compile a temporary project (via "GenerateTemporaryTargetAssembly" target), | ||
| and that temp project doesn't have "ResolveReferences" target we expect. | ||
| This leads to the runtime's generator not being removed and to a compile-time error CS0757. This additional target resolves the problem. --> | ||
| <Target Name="_Microsoft_Extensions_Telemetry_AbstractionsRemoveAnalyzersWPF" | ||
| Condition="'$(DisableMicrosoftExtensionsLoggingSourceGenerator)' == 'true'" | ||
| AfterTargets="RemoveDuplicateAnalyzers"> | ||
| <ItemGroup> | ||
| <_Microsoft_Extensions_Logging_AbstractionsAnalyzerWPF | ||
| Include="@(Analyzer)" | ||
| Condition="'%(Analyzer.AssemblyName)' == 'Microsoft.Extensions.Logging.Generators' Or | ||
| '%(Analyzer.NuGetPackageId)' == 'Microsoft.Extensions.Logging.Abstractions'" /> | ||
| </ItemGroup> | ||
| <!-- Remove Microsoft.Extensions.Logging.Abstractions Analyzer for WPF projects --> | ||
| <ItemGroup> | ||
| <Analyzer Remove="@(_Microsoft_Extensions_Logging_AbstractionsAnalyzerWPF)" /> | ||
| </ItemGroup> | ||
| </Target> | ||
| </Project> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that the two targets had the same name was very intentional, as we want to make sure that the targets are replaced such that only one ever runs in a project evaluation. Do we have a repro project where we can clearly see the issue? I'd like to see that to better understand the problem and validate the RCA made here, as I don't think that target naming colissions was the problem.