Don't specify MaxOutputTokens for EquivalenceEvaluator #7006
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-ai-eval
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the MaxOutputTokens limitation from the EquivalenceEvaluator to address compatibility issues with certain AI models. The change allows the evaluator to work with models that don't support the MaxOutputTokens parameter or handle it differently.
Key changes:
- Removed the MaxOutputTokens = 16 setting from the ChatOptions
- Added documentation explaining why MaxOutputTokens is intentionally not set
- Updated comments to reference three related GitHub issues
stephentoub
approved these changes
Nov 3, 2025
This was referenced Nov 11, 2025
Merged
Merged
Merged
Merged
Open
Open
This was referenced Nov 13, 2025
Open
Open
Open
Merged
Bump Microsoft.Extensions.ServiceDiscovery from 9.5.1 to 10.0.0
dotnet-presentations/ai-workshop#264
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7002
Microsoft Reviewers: Open in CodeFlow