Update AsOpenAIResponseItems to roundtrip User AIContent ResponseItems #6931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Assistant and Tool messages we're directly roundtripping RawRepresentations that are ResponseItems, but not for User messages. Fix that.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Rounds out OpenAI response item conversion so that AIContent.RawRepresentation values that are full ResponseItem instances in user messages are directly round‑tripped (previously only done for assistant/tool messages).
- Adds a new switch case in ToOpenAIResponseItems to yield RawRepresentation when it is a ResponseItem.
- Introduces a unit test validating roundtrip behavior for several ResponseItem types in user and assistant messages.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/Libraries/Microsoft.Extensions.AI.OpenAI.Tests/OpenAIConversionTests.cs | Adds a new unit test to assert raw ResponseItem roundtripping from user/assistant messages. |
| src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIResponsesChatClient.cs | Adds a switch case to emit RawRepresentation directly when it is a ResponseItem. |
src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIResponsesChatClient.cs
Outdated
Show resolved
Hide resolved
crickman
approved these changes
Oct 18, 2025
Previously a ResponseItem between two TextContents, for example, would end up being yielded before the text content that came before it. Instead, yield a response item for each group between directly-mapped items. Also fix missing RawRepresentation on McpServerToolApprovalResponseContent.
jeffhandley
approved these changes
Oct 18, 2025
src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIResponsesChatClient.cs
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIResponsesChatClient.cs
Show resolved
Hide resolved
jeffhandley
pushed a commit
to jeffhandley/extensions
that referenced
this pull request
Oct 21, 2025
dotnet#6931) * Update AsOpenAIResponseItems to roundtrip User AIContent ResponseItems For Assistant and Tool messages we're directly roundtripping RawRepresentations that are ResponseItems, but not for User messages. Fix that. * Ensure ordering of AIContent-to-ResponseItem mapping Previously a ResponseItem between two TextContents, for example, would end up being yielded before the text content that came before it. Instead, yield a response item for each group between directly-mapped items. Also fix missing RawRepresentation on McpServerToolApprovalResponseContent.
jeffhandley
pushed a commit
to jeffhandley/extensions
that referenced
this pull request
Oct 21, 2025
dotnet#6931) * Update AsOpenAIResponseItems to roundtrip User AIContent ResponseItems For Assistant and Tool messages we're directly roundtripping RawRepresentations that are ResponseItems, but not for User messages. Fix that. * Ensure ordering of AIContent-to-ResponseItem mapping Previously a ResponseItem between two TextContents, for example, would end up being yielded before the text content that came before it. Instead, yield a response item for each group between directly-mapped items. Also fix missing RawRepresentation on McpServerToolApprovalResponseContent.
jeffhandley
pushed a commit
to jeffhandley/extensions
that referenced
this pull request
Oct 21, 2025
dotnet#6931) * Update AsOpenAIResponseItems to roundtrip User AIContent ResponseItems For Assistant and Tool messages we're directly roundtripping RawRepresentations that are ResponseItems, but not for User messages. Fix that. * Ensure ordering of AIContent-to-ResponseItem mapping Previously a ResponseItem between two TextContents, for example, would end up being yielded before the text content that came before it. Instead, yield a response item for each group between directly-mapped items. Also fix missing RawRepresentation on McpServerToolApprovalResponseContent.
This was referenced Nov 11, 2025
Merged
Merged
This was referenced Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Assistant and Tool messages we're directly roundtripping RawRepresentations that are ResponseItems, but not for User messages. Fix that.
Microsoft Reviewers: Open in CodeFlow