Skip to content

Add Workstream, Stage, and PackageValidationBaselineVersion metadata to ServiceDiscovery libraries #6919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joperezr merged 6 commits into from
Oct 15, 2025
Merged

Add Workstream, Stage, and PackageValidationBaselineVersion metadata to ServiceDiscovery libraries #6919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
19c636b
Initial plan
Copilot Oct 14, 2025
6e76991
Add Workstream and Stage metadata to ServiceDiscovery libraries
Copilot Oct 14, 2025
4fbe2dd
Add PackageValidationBaselineVersion to ServiceDiscovery projects
Copilot Oct 14, 2025
d4b4ad6
Only set default PackageValidationBaselineVersion when not explicitly…
joperezr Oct 14, 2025
4688130
Add StrongNameKeyId and test coverage metadata to ServiceDiscovery pr…
joperezr Oct 14, 2025
adb122e
Set StrongNameKeyId to Open in ServiceDiscovery test projects
joperezr Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/MSBuild/Packaging.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/overview -->
<EnablePackageValidation>true</EnablePackageValidation>

<PackageValidationBaselineVersion Condition=" '$(Stage)' == 'normal' ">9.8.0</PackageValidationBaselineVersion>
<PackageValidationBaselineVersion Condition="'$(Stage)' == 'normal' and '$(PackageValidationBaselineVersion)' == ''">9.8.0</PackageValidationBaselineVersion>
</PropertyGroup>

<!-- Verify that the minimum supported TFM is actually used. -->
Expand Down
10 changes: 9 additions & 1 deletion ...s.ServiceDiscovery.Abstractions/Microsoft.Extensions.ServiceDiscovery.Abstractions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,21 @@
<TargetFrameworks>$(TargetFrameworks);netstandard2.0</TargetFrameworks>
<IsPackable>true</IsPackable>
<Description>Provides abstractions for service discovery. Interfaces defined in this package are implemented in Microsoft.Extensions.ServiceDiscovery and other service discovery packages.</Description>
<PackageIconFullPath>$(DefaultDotnetIconFullPath)</PackageIconFullPath>
<StrongNameKeyId>Open</StrongNameKeyId>
<RootNamespace>Microsoft.Extensions.ServiceDiscovery</RootNamespace>
<!-- https://github.com/dotnet/extensions/issues/6871 tracks enabling these -->
<NoWarn>$(NoWarn);S1144;CA1002;S2365;SA1642;IDE0040;CA1307;EA0009;LA0003</NoWarn>
<ImplicitUsings>enable</ImplicitUsings>
</PropertyGroup>

<PropertyGroup>
<Workstream>ServiceDiscovery</Workstream>
<Stage>normal</Stage>
<PackageValidationBaselineVersion>9.5.1</PackageValidationBaselineVersion>
<MinCodeCoverage>75</MinCodeCoverage>
<MinMutationScore>75</MinMutationScore>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" />
Expand Down
Empty file added ...ons.ServiceDiscovery.Abstractions/Microsoft.Extensions.ServiceDiscovery.Abstractions.json
View file
Open in desktop
Empty file.
10 changes: 9 additions & 1 deletion ...icrosoft.Extensions.ServiceDiscovery.Dns/Microsoft.Extensions.ServiceDiscovery.Dns.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,21 @@
<TargetFrameworks>$(NetCoreTargetFrameworks)</TargetFrameworks>
<IsPackable>true</IsPackable>
<Description>Provides extensions to HttpClient to resolve well-known hostnames to concrete endpoints based on DNS records. Useful for service resolution in orchestrators such as Kubernetes.</Description>
<PackageIconFullPath>$(DefaultDotnetIconFullPath)</PackageIconFullPath>
<StrongNameKeyId>Open</StrongNameKeyId>
<!-- https://github.com/dotnet/extensions/issues/6871 tracks enabling these -->
<NoWarn>$(NoWarn);IDE0018;IDE0025;IDE0032;IDE0040;IDE0058;IDE0250;IDE0251;IDE1006;CA1304;CA1307;CA1309;CA1310;CA1849;CA2000;CA2213;CA2217;S125;S1135;S1226;S2344;S3626;S4022;SA1108;SA1120;SA1128;SA1129;SA1204;SA1205;SA1214;SA1400;SA1405;SA1408;SA1515;SA1600;SA1629;SA1642;SA1649;EA0001;EA0009;EA0014;LA0001;LA0003;LA0008;VSTHRD200</NoWarn>
<ImplicitUsings>enable</ImplicitUsings>
<DisableMicrosoftExtensionsLoggingSourceGenerator>false</DisableMicrosoftExtensionsLoggingSourceGenerator>
</PropertyGroup>

<PropertyGroup>
<Workstream>ServiceDiscovery</Workstream>
<Stage>normal</Stage>
<PackageValidationBaselineVersion>9.5.1</PackageValidationBaselineVersion>
<MinCodeCoverage>75</MinCodeCoverage>
<MinMutationScore>75</MinMutationScore>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="DnsClient" />
<PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" />
Expand Down
Empty file added .../Microsoft.Extensions.ServiceDiscovery.Dns/Microsoft.Extensions.ServiceDiscovery.Dns.json
View file
Open in desktop
Empty file.
10 changes: 9 additions & 1 deletion ...rosoft.Extensions.ServiceDiscovery.Yarp/Microsoft.Extensions.ServiceDiscovery.Yarp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,20 @@
<Nullable>enable</Nullable>
<IsPackable>true</IsPackable>
<Description>Provides extensions for service discovery for the YARP reverse proxy.</Description>
<PackageIconFullPath>$(DefaultDotnetIconFullPath)</PackageIconFullPath>
<StrongNameKeyId>Open</StrongNameKeyId>
<!-- https://github.com/dotnet/extensions/issues/6871 tracks enabling these -->
<NoWarn>$(NoWarn);IDE0018;IDE0025;IDE0032;IDE0040;IDE0058;IDE0250;IDE0251;IDE1006;CA1304;CA1307;CA1309;CA1310;CA1849;CA2000;CA2213;CA2217;S125;S1135;S1226;S2344;S2692;S3626;S4022;SA1108;SA1120;SA1128;SA1129;SA1204;SA1205;SA1214;SA1400;SA1405;SA1408;SA1414;SA1515;SA1600;SA1615;SA1629;SA1642;SA1649;EA0001;EA0009;EA0014;LA0001;LA0003;LA0008;VSTHRD200</NoWarn>
<ImplicitUsings>enable</ImplicitUsings>
</PropertyGroup>

<PropertyGroup>
<Workstream>ServiceDiscovery</Workstream>
<Stage>normal</Stage>
<PackageValidationBaselineVersion>9.5.1</PackageValidationBaselineVersion>
<MinCodeCoverage>75</MinCodeCoverage>
<MinMutationScore>75</MinMutationScore>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Yarp.ReverseProxy" />
</ItemGroup>
Expand Down
Empty file added ...icrosoft.Extensions.ServiceDiscovery.Yarp/Microsoft.Extensions.ServiceDiscovery.Yarp.json
View file
Open in desktop
Empty file.
10 changes: 9 additions & 1 deletion ...raries/Microsoft.Extensions.ServiceDiscovery/Microsoft.Extensions.ServiceDiscovery.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,21 @@
<TargetFrameworks>$(TargetFrameworks);netstandard2.0</TargetFrameworks>
<IsPackable>true</IsPackable>
<Description>Provides extensions to HttpClient that enable service discovery based on configuration.</Description>
<PackageIconFullPath>$(DefaultDotnetIconFullPath)</PackageIconFullPath>
<StrongNameKeyId>Open</StrongNameKeyId>
<!-- https://github.com/dotnet/extensions/issues/6871 tracks enabling these -->
<NoWarn>$(NoWarn);CS8600;CS8602;CS8604;IDE0040;IDE0055;IDE0058;IDE1006;CA1307;CA1310;CA1849;CA2007;CA2213;SA1204;SA1128;SA1205;SA1405;SA1612;SA1623;SA1625;SA1642;S1144;S1449;S2302;S2692;S3872;S4457;EA0000;EA0009;EA0014;LA0001;LA0003;LA0008;VSTHRD200</NoWarn>
<ImplicitUsings>enable</ImplicitUsings>
<DisableMicrosoftExtensionsLoggingSourceGenerator>false</DisableMicrosoftExtensionsLoggingSourceGenerator>
</PropertyGroup>

<PropertyGroup>
<Workstream>ServiceDiscovery</Workstream>
<Stage>normal</Stage>
<PackageValidationBaselineVersion>9.5.1</PackageValidationBaselineVersion>
<MinCodeCoverage>75</MinCodeCoverage>
<MinMutationScore>75</MinMutationScore>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Http" />
<InternalsVisibleTo Include="Microsoft.Extensions.ServiceDiscovery.Tests" />
Expand Down
Empty file added ...ibraries/Microsoft.Extensions.ServiceDiscovery/Microsoft.Extensions.ServiceDiscovery.json
View file
Open in desktop
Empty file.
1 change: 1 addition & 0 deletions ...iscovery.Dns.Tests.Fuzzing/Microsoft.Extensions.ServiceDiscovery.Dns.Tests.Fuzzing.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<OutputType>Exe</OutputType>
<StrongNameKeyId>Open</StrongNameKeyId>
<!-- https://github.com/dotnet/extensions/issues/6871 tracks enabling these -->
<NoWarn>$(NoWarn);IDE0040;IDE0061;IDE1006;S5034;SA1400;VSTHRD002</NoWarn>
</PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions ...ensions.ServiceDiscovery.Dns.Tests/Microsoft.Extensions.ServiceDiscovery.Dns.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<TargetFrameworks>$(TestNetCoreTargetFrameworks)</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<StrongNameKeyId>Open</StrongNameKeyId>
<!-- https://github.com/dotnet/extensions/issues/6871 tracks enabling these -->
<NoWarn>$(NoWarn);IDE0004;IDE0017;IDE0040;IDE0055;IDE1006;CA1012;CA1031;CA1063;CA1816;CA2000;S103;S107;S1067;S1121;S1128;S1135;S1144;S1186;S2148;S3442;S3459;S4136;SA1106;SA1127;SA1204;SA1208;SA1210;SA1128;SA1316;SA1400;SA1402;SA1407;SA1414;SA1500;SA1513;SA1515;VSTHRD003</NoWarn>
</PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions ...soft.Extensions.ServiceDiscovery.Tests/Microsoft.Extensions.ServiceDiscovery.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<PropertyGroup>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<StrongNameKeyId>Open</StrongNameKeyId>
<!-- https://github.com/dotnet/extensions/issues/6871 tracks enabling these -->
<NoWarn>$(NoWarn);IDE0004;IDE0040;IDE0055;IDE1006;CA2000;S1121;S1128;SA1316;SA1500;SA1513</NoWarn>
</PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions ...sions.ServiceDiscovery.Yarp.Tests/Microsoft.Extensions.ServiceDiscovery.Yarp.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<TargetFrameworks>$(TestNetCoreTargetFrameworks)</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<StrongNameKeyId>Open</StrongNameKeyId>
<!-- https://github.com/dotnet/extensions/issues/6871 tracks enabling these -->
<NoWarn>$(NoWarn);CA2000;S103;S1144;S3459;S4136;SA1208;SA1210;VSTHRD003</NoWarn>
</PropertyGroup>
Expand Down
Loading