Skip to content

Fix METGEN004 error message: print return type in ErrorInvalidMethodReturnType #6905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2025
Merged

Fix METGEN004 error message: print return type in ErrorInvalidMethodReturnType #6905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bb91e2
Pass the right parameter to `ErrorInvalidMethodReturnType` message
Oct 9, 2025
d0fbc4f
Merge branch 'main' into ErrorInvalidMethodReturnType-wrong-param
eduherminio Oct 9, 2025
15d1dcc
Merge branch 'main' into ErrorInvalidMethodReturnType-wrong-param
eduherminio Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Generators/Microsoft.Gen.Metrics/Parser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ private bool CheckMethodReturnType(IMethodSymbol methodSymbol)
returnType.TypeKind != TypeKind.Error)
{
// Make sure return type is not from existing known type
Diag(DiagDescriptors.ErrorInvalidMethodReturnType, methodSymbol.ReturnType.GetLocation(), methodSymbol.Name);
Diag(DiagDescriptors.ErrorInvalidMethodReturnType, returnType.GetLocation(), returnType.ToDisplayString(SymbolDisplayFormat.MinimallyQualifiedFormat));
return false;
}

Expand Down
1 change: 1 addition & 0 deletions test/Generators/Microsoft.Gen.Metrics/Unit/ParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ class CustomClass {{ }}

_ = Assert.Single(d);
Assert.Equal(DiagDescriptors.ErrorInvalidMethodReturnType.Id, d[0].Id);
Assert.Contains($"must not return '{returnType}'", d[0].GetMessage());
}

[Theory]
Expand Down
Loading