-
Notifications
You must be signed in to change notification settings - Fork 839
Add support for HostApplicationBuilder
in AmbientMetadata extension
#6867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HostApplicationBuilder
in AmbientMetadata extension
#6867
Conversation
HostApplicationBuilder
in AmbientMetadata extension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for HostApplicationBuilder
alongside the existing IHostBuilder
support in the AmbientMetadata extension library. This enhancement allows users to configure application metadata using the newer IHostApplicationBuilder
interface.
- Introduces a new generic
UseApplicationMetadata<TBuilder>
extension method constrained toIHostApplicationBuilder
- Updates the API baseline manifest to reflect the new method signature
- Adds comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
ApplicationMetadataHostBuilderExtensions.cs |
Adds new generic extension method for IHostApplicationBuilder support |
Microsoft.Extensions.AmbientMetadata.Application.json |
Updates API baseline manifest with new method and version bump |
README.md |
Documents the new generic extension method signature |
ApplicationMetadataExtensionsTests.cs |
Adds null argument validation tests for the new extension method |
AcceptanceTests.cs |
Adds integration tests verifying the new extension method works correctly |
Closes #6509.
Detailed info there, as it's the API proposal.
Microsoft Reviewers: Open in CodeFlow