Make serviceKey nullable for ImageGenerator and ISpeechToTextClient #6807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aligned with AddKeyedEmbeddingGenerator and AddKeyedChatClient.
auto-merge was automatically disabled
September 14, 2025 17:01
Head branch was pushed to by a user without write access
|
Ope sorry, I didn't test it. There was a null check too. |
|
Can you add tests, too, please? |
|
Sure, I'll setup a workspace. |
verdie-g
changed the title
eiriktsarpalis
approved these changes
Sep 15, 2025
This was referenced Oct 14, 2025
Open
Merged
This was referenced Oct 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligned with AddKeyedEmbeddingGenerator and AddKeyedChatClient.
Microsoft Reviewers: Open in CodeFlow