Skip to content

Remove debug-level logging of updates in LoggingChatClient #6425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

Remove debug-level logging of updates in LoggingChatClient #6425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/Libraries/Microsoft.Extensions.AI/ChatCompletion/LoggingChatClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,16 +153,9 @@ public override async IAsyncEnumerable<ChatResponseUpdate> GetStreamingResponseA
throw;
}

if (_logger.IsEnabled(LogLevel.Debug))
if (_logger.IsEnabled(LogLevel.Trace))
{
if (_logger.IsEnabled(LogLevel.Trace))
{
LogStreamingUpdateSensitive(AsJson(update));
}
else
{
LogStreamingUpdate();
}
LogStreamingUpdateSensitive(AsJson(update));
}

yield return update;
Expand Down Expand Up @@ -190,9 +183,6 @@ public override async IAsyncEnumerable<ChatResponseUpdate> GetStreamingResponseA
[LoggerMessage(LogLevel.Trace, "{MethodName} completed: {ChatResponse}.")]
private partial void LogCompletedSensitive(string methodName, string chatResponse);

[LoggerMessage(LogLevel.Debug, "GetStreamingResponseAsync received update.")]
private partial void LogStreamingUpdate();

[LoggerMessage(LogLevel.Trace, "GetStreamingResponseAsync received update: {ChatResponseUpdate}")]
private partial void LogStreamingUpdateSensitive(string chatResponseUpdate);

Expand Down
2 changes: 0 additions & 2 deletions test/Libraries/Microsoft.Extensions.AI.Tests/ChatCompletion/LoggingChatClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,6 @@ static async IAsyncEnumerable<ChatResponseUpdate> GetUpdatesAsync()
{
Assert.Collection(logs,
entry => Assert.True(entry.Message.Contains("GetStreamingResponseAsync invoked.") && !entry.Message.Contains("biggest animal")),
entry => Assert.True(entry.Message.Contains("GetStreamingResponseAsync received update.") && !entry.Message.Contains("blue")),
entry => Assert.True(entry.Message.Contains("GetStreamingResponseAsync received update.") && !entry.Message.Contains("whale")),
entry => Assert.Contains("GetStreamingResponseAsync completed.", entry.Message));
}
else
Expand Down
Loading