Add Disk IO time metric for Windows in ResourceMonitoring #6338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makazeu
commented
Apr 28, 2025
...osoft.Extensions.Diagnostics.ResourceMonitoring/Windows/Disk/WindowsDiskIoRatePerfCounter.cs
Show resolved
Hide resolved
|
cc @evgenyfedorov2 please help review, thanks |
...aries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Windows/Disk/WindowsDiskMetrics.cs
Outdated
Show resolved
Hide resolved
...osoft.Extensions.Diagnostics.ResourceMonitoring/Windows/Disk/WindowsDiskIoTimePerfCounter.cs
Outdated
Show resolved
Hide resolved
evgenyfedorov2
approved these changes
May 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Disk IO time metric (
system.disk.io_time) for Windows in ResourceMonitoring.This is a recommended metric according to OpenTelemetry specs.
The metric value represents the real elapsed time (“wall clock”) used in the I/O path (time from operations running in parallel are not counted). Measured as:
This PR provides the Windows implementation for the metric.
Tested in Grafana + Prometheus
And tested in Geneva
Linked: #6181 & #5842
Microsoft Reviewers: Open in CodeFlow