-
Notifications
You must be signed in to change notification settings - Fork 839
Added support for OTel semantic conventions for GenAI with Aspire #6210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jmatthiesen
merged 5 commits into
mbuck/chat-template-aspire
from
jmatthiesen/aspireTemplateUpdates
Mar 28, 2025
Merged
Added support for OTel semantic conventions for GenAI with Aspire #6210
jmatthiesen
merged 5 commits into
mbuck/chat-template-aspire
from
jmatthiesen/aspireTemplateUpdates
Mar 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
....AI.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.ServiceDefaults/Extensions.cs
Outdated
Show resolved
Hide resolved
...tensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.Web/Program.Aspire.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll also need to update the template snapshots before these changes hit main
.
....AI.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.ServiceDefaults/Extensions.cs
Outdated
Show resolved
Hide resolved
…tWithCustomData/ChatWithCustomData-CSharp.Web/Program.Aspire.cs Co-authored-by: Steve Sanderson <[email protected]>
jmatthiesen
commented
Mar 28, 2025
...tensions.AI.Templates/src/ChatWithCustomData/ChatWithCustomData-CSharp.Web/Program.Aspire.cs
Show resolved
Hide resolved
MackinnonBuck
approved these changes
Mar 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some additional meters/sources for OTel to include generative AI messages and properties, enabling the semantic conventions for generative AI. With these updates we can more detailed traces for chat interactions (previously the different calls for AI models were not included):
As well as details such as message contents, token usage, etc.
Microsoft Reviewers: Open in CodeFlow