Skip to content

Work around fixed bug in System.Memory.Data #5569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Work around fixed bug in System.Memory.Data #5569

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f78bc7
Workaround fixed bug in System.Memory.Data
stephentoub Oct 24, 2024
a48b840
Add pragma warning and update condition check
stephentoub Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIChatClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,10 @@

existing.CallId ??= toolCallUpdate.ToolCallId;
existing.Name ??= toolCallUpdate.FunctionName;
if (toolCallUpdate.FunctionArgumentsUpdate is not null)
if (toolCallUpdate.FunctionArgumentsUpdate is { } update &&
update.ToMemory().Length != 0) // workaround for https://github.com/dotnet/runtime/issues/68262 in 6.0.0 package

Check failure on line 268 in src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIChatClient.cs

View check run for this annotation

Azure Pipelines / extensions-ci (Correctness WarningsCheck)

src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIChatClient.cs#L268 

src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIChatClient.cs(268,56): error SA1108: (NETCORE_ENGINEERING_TELEMETRY=Build) Block statements should not contain embedded comments (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1108.md)

Check failure on line 268 in src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIChatClient.cs

View check run for this annotation

Azure Pipelines / extensions-ci (Correctness WarningsCheck)

src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIChatClient.cs#L268 

src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIChatClient.cs(268,56): error SA1108: (NETCORE_ENGINEERING_TELEMETRY=Build) Block statements should not contain embedded comments (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1108.md)

Check failure on line 268 in src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIChatClient.cs

View check run for this annotation

Azure Pipelines / extensions-ci (Correctness WarningsCheck)

src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIChatClient.cs#L268 

src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIChatClient.cs(268,56): error SA1108: (NETCORE_ENGINEERING_TELEMETRY=Build) Block statements should not contain embedded comments (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1108.md)

Check failure on line 268 in src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIChatClient.cs

View check run for this annotation

Azure Pipelines / extensions-ci (Correctness WarningsCheck)

src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIChatClient.cs#L268 

src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIChatClient.cs(268,56): error SA1108: (NETCORE_ENGINEERING_TELEMETRY=Build) Block statements should not contain embedded comments (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1108.md)
{
_ = (existing.Arguments ??= new()).Append(toolCallUpdate.FunctionArgumentsUpdate);
_ = (existing.Arguments ??= new()).Append(update.ToString());
}
}
}
Expand Down
Loading