Skip to content

First cut of code ownership #5486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

First cut of code ownership #5486

merged 1 commit into from
Oct 9, 2024

Conversation

@RussKie
Copy link
Contributor

@RussKie RussKie commented Oct 9, 2024 •
edited by dotnet-policy-service bot
Loading

Contributes to #4656

Microsoft Reviewers: Open in CodeFlow

@mgravell
Copy link
Contributor

mgravell commented Oct 9, 2024 •
edited
Loading

LGTM; possible addition of dotnet-extensions-telemetry against Microsoft.Extensions.Telemetry etc (the usual quad)?

@RussKie
Copy link
Contributor Author

RussKie commented Oct 9, 2024

...possible addition of dotnet-extensions-telemetry against Microsoft.Extensions.Telemetry etc (the usual quad)?

That's the eventual plan. We're in a process of defining the teams and assignments with @mwierzchowski.

@RussKie RussKie merged commit 7ada97e into dotnet:main Oct 9, 2024
2 checks passed
@RussKie RussKie deleted the codeowners branch October 9, 2024 23:06
@RussKie RussKie linked an issue Oct 9, 2024 that may be closed by this pull request
we need area owners/ codeowners file #4656
Closed
joperezr
joperezr reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks @RussKie!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joperezr joperezr joperezr left review comments

@stephentoub stephentoub Awaiting requested review from stephentoub

+1 more reviewer

@mgravell mgravell mgravell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RussKie RussKie

Labels

area-infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

we need area owners/ codeowners file

3 participants

@RussKie @mgravell @joperezr