[master] Update dependencies from dotnet/core-setup dotnet/arcade

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/core-setup

• Build: 20190623.05
• Date Produced: 6/24/2019 4:27 AM
• Commit: 08e144c8651632da7bf1fbab409d27787ce6aa4a
• Branch: refs/heads/master
• Updates:
  • NETStandard.Library.Ref -> 2.1.0-preview7-27823-05
  • Microsoft.NETCore.App.Ref -> 3.0.0-preview7-27823-05
  • Microsoft.NETCore.App.Runtime.win-x64 -> 3.0.0-preview7-27823-05

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

• Microsoft.Win32.Registry -> 4.6.0-preview7.19320.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.ComponentModel.Annotations -> 4.6.0-preview7.19320.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Diagnostics.DiagnosticSource -> 4.6.0-preview7.19320.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Diagnostics.EventLog -> 4.6.0-preview7.19320.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.IO.Pipelines -> 4.6.0-preview7.19320.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Reflection.Metadata -> 1.7.0-preview7.19320.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Runtime.CompilerServices.Unsafe -> 4.6.0-preview7.19320.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Security.Cryptography.Cng -> 4.6.0-preview7.19320.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Security.Cryptography.Xml -> 4.6.0-preview7.19320.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.ServiceProcess.ServiceController -> 4.6.0-preview7.19320.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Text.Encodings.Web -> 4.6.0-preview7.19320.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• System.Text.Json -> 4.6.0-preview7.19320.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
• Microsoft.NETCore.Platforms -> 3.0.0-preview7.19320.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)

From https://github.com/dotnet/arcade

• Build: 20190623.4
• Date Produced: 6/24/2019 7:07 AM
• Commit: 9946534da4f73e6242ca105f6798ab58119c9ab0
• Branch: refs/heads/master
• Updates:
  • Microsoft.DotNet.Arcade.Sdk -> 1.0.0-beta.19323.4
  • Microsoft.DotNet.GenAPI -> 1.0.0-beta.19323.4
  • Microsoft.DotNet.Helix.Sdk -> 2.0.0-beta.19323.4

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: Extensions-ci, Extensions-ci (OSX Release), Extensions-ci (OSX Debug), Extensions-ci (Ubuntu 16.04 Release), Extensions-ci (Windows Release), Extensions-ci (Ubuntu 16.04 Debug), Extensions-ci (Windows debug)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[dougbu]

@anurse please have someone take a look at the consistent test failures. I think they're all in EventSourceLoggerTest.

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: Extensions-ci, Extensions-ci (Ubuntu 16.04 Release), Extensions-ci (Ubuntu 16.04 Debug), Extensions-ci (OSX Release), Extensions-ci (OSX Debug), Extensions-ci (Windows Release), Extensions-ci (Windows debug)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[analogrelay]

Seems like it could have been a System.Text.Json regression.

[analogrelay]

@BrennanConroy please take a look.

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: Extensions-ci, Extensions-ci (Ubuntu 16.04 Release), Extensions-ci (Ubuntu 16.04 Debug), Extensions-ci (OSX Release), Extensions-ci (Windows Release), Extensions-ci (OSX Debug), Extensions-ci (Windows debug)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[BrennanConroy]

Exception.ToString was changed in 3.0 to now put inner exceptions on new lines: dotnet/coreclr#25185

This will make testing a little ugly as we test on net472 and netcoreapp3.0 and we want to verify the contents of the messages (which include exceptions in some cases).

[analogrelay]

Perhaps adding an ExceptionComparer class that has #if NETCOREAPP3_0 logic and #if NET472 logic.

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: Extensions-ci, Extensions-ci (Ubuntu 16.04 Release), Extensions-ci (Ubuntu 16.04 Debug), Extensions-ci (OSX Release), Extensions-ci (Windows Release), Extensions-ci (OSX Debug), Extensions-ci (Windows debug)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[BrennanConroy]

I was thinking either making a method GetNewLineOnNetCoreApp that we place in the expected output string, or make an #if around the two affected cases and add the newline in the netcoreapp ones.

[dotnet-maestro]

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

• ✔️ Standard Merge Policies Succeeded - Successful checks: Extensions-ci, Extensions-ci (Test: Linux Source Build), Extensions-ci (OSX Release), Extensions-ci (OSX Debug), Extensions-ci (Ubuntu 16.04 Release), Extensions-ci (Ubuntu 16.04 Debug), Extensions-ci (Windows Release), Extensions-ci (Windows debug), Extensions-ci (Code check)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[BrennanConroy]

@anurse Take a quick look at the change before the bot auto-merges :)

[analogrelay]

Is there a way to use a single value and have some kind of "transform" applied in either NETCOREAPP or !NETCOREAPP instead of using separate values entirely?

[BrennanConroy]

Yeah:

$"some json string stuff, exception{GetNewLineOnNetCoreApp()} ---> inner exception"

static string GetNewLineOnNetCoreApp()
{
#if NETCOREAPP
    return Environment.NewLine.Replace(...);
#else
    return "";
#endif
}