Make JSRuntime.Current non-public #1118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
reviewed
Feb 15, 2019
| /// Gets the current <see cref="IJSRuntime"/>, if any. | ||
| /// </summary> | ||
| public static IJSRuntime Current => _currentJSRuntime.Value; | ||
| internal static IJSRuntime Current => _currentJSRuntime.Value; |
There was a problem hiding this comment.
It says remove. But from looking at it, I can see that it is not removed.
There was a problem hiding this comment.
Indeed. Could the entire JSRuntime.cs file be removed?
There was a problem hiding this comment.
Not in any trivial way. It's used from a static context by DotnetNetDispatcher to notify of completion:
- https://github.com/aspnet/Extensions/blob/master/src/JSInterop/Microsoft.JSInterop/src/DotNetDispatcher.cs#L99
- https://github.com/aspnet/Extensions/blob/master/src/JSInterop/Microsoft.JSInterop/src/DotNetDispatcher.cs#L192-L193
In addition, there's also some pretty gnarly coupling of the runtime \ SimpleJSON's serialization and object tracking. I was hoping not to mess around with the code here if it's meant to be cleaned up soon.
pranavkm
force-pushed
the
prkrishn/remove-jsruntime-current
branch
from
3a67975 to
3b46605
Compare
|
Bump |
rynowak
approved these changes
Feb 19, 2019
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 12, 2020
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 15, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/aspnetcore#6828