Query: Update materialization marking for set operations #8213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
commented
Apr 18, 2017
| @@ -1,8 +1,10 @@ | |||
| // Copyright (c) .NET Foundation. All rights reserved. | |||
There was a problem hiding this comment.
@ajcvickers @Eilon - Just notifying that this file did not license not earlier (in current codebase) if there are any consequences of that.
There was a problem hiding this comment.
Should be fine. Thanks for adding it.
There was a problem hiding this comment.
If there's ever a missing license in a file, no worries, just add it in.
smitpatel
requested review from
anpete and
maumar
and removed request for
anpete
maumar
approved these changes
Apr 18, 2017
ajcvickers
approved these changes
Apr 19, 2017
Add test for set operation followed group by not translating correctly Issue #6658
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for set operation followed group by not translating correctly Issue #6658
This PR does not fix the issue
We were checking for type matching when marking set operations for materialization. That should not be required as compiler would make sure that types are compatible.