Skip to content

Use migration ID as scaffolded migration type name #37841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndriySvyryd merged 5 commits into from
Mar 4, 2026
Merged

Use migration ID as scaffolded migration type name #37841

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c022c8b
Initial plan
Copilot Mar 4, 2026
f3c4724
Append timestamp to scaffolded migration type names
Copilot Mar 4, 2026
7317eff
Use migration ID directly as the type name
Copilot Mar 4, 2026
035f635
Fix test baselines for migration ID-based type names
Copilot Mar 4, 2026
9c8f56a
Update test/EFCore.Design.Tests/Migrations/Design/MigrationScaffolder…
AndriySvyryd Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/EFCore.Design/Migrations/Design/MigrationsScaffolder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,13 +174,13 @@ public virtual ScaffoldedMigration ScaffoldMigration(
var codeGenerator = Dependencies.MigrationsCodeGeneratorSelector.Select(language);
var migrationCode = codeGenerator.GenerateMigration(
migrationNamespace,
migrationName,
migrationId,
upOperations,
Comment thread
AndriySvyryd marked this conversation as resolved.
downOperations);
var migrationMetadataCode = codeGenerator.GenerateMetadata(
migrationNamespace,
_contextType,
migrationName,
migrationId,
migrationId,
Dependencies.Model);
var modelSnapshotCode = codeGenerator.GenerateSnapshot(
Expand Down
12 changes: 12 additions & 0 deletions test/EFCore.Design.Tests/Migrations/Design/MigrationScaffolderTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,18 @@ public void ScaffoldMigration_can_override_namespace()
Assert.Equal("OverrideNamespace.OverrideSubNamespace", migration.SnapshotSubnamespace);
}

[ConditionalFact]
public void ScaffoldMigration_appends_timestamp_to_type_name()
Comment thread
AndriySvyryd marked this conversation as resolved.
Outdated
{
var scaffolder = CreateMigrationScaffolder<ContextWithSnapshot>();

var migration = scaffolder.ScaffoldMigration("DateTime", "WebApplication1");

Assert.Contains($"public partial class _{migration.MigrationId} : Migration", migration.MigrationCode);
Assert.Contains($"partial class _{migration.MigrationId}", migration.MetadataCode);
Assert.Contains($"[Migration(\"{migration.MigrationId}\")]", migration.MetadataCode);
}

private IMigrationsScaffolder CreateMigrationScaffolder<TContext>()
where TContext : DbContext, new()
{
Expand Down
Loading