Skip to content

Remove checked-in nuspec files to resolve build issues #37826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndriySvyryd merged 21 commits into from
Mar 3, 2026
Merged

Remove checked-in nuspec files to resolve build issues #37826

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ba19496
Initial plan
Copilot Mar 2, 2026
36dcbdb
Remove checked-in nuspec files and convert to MSBuild properties
Copilot Mar 2, 2026
c01eba6
Changes before error encountered
Copilot Mar 2, 2026
ccbce7a
Fix package content: restore PDB entries, suppress net472 deps in Tas…
Copilot Mar 2, 2026
b22182a
Rename all PACKAGE.md files to README.md
Copilot Mar 2, 2026
08c59e3
Remove PDB files from main packages, add RemovePdbFromMainPackage target
Copilot Mar 2, 2026
a1ba6f4
Rename RemovePdbFromMainPackage target to ExcludePdbFiles for clarity
Copilot Mar 2, 2026
a30459c
Keep PDB files in symbols package only: add StripPdbFromMainPackage i…
Copilot Mar 2, 2026
837e44c
Extract StripPdbFromNupkg task to shared eng/StripPdbFromNupkg.targets
Copilot Mar 2, 2026
366d4fb
Replace StripPdbFromNupkg with two-pass pack for correct PDB handling
Copilot Mar 3, 2026
52d43d7
Address reviewer feedback: revert Directory.Packages.props, fix paths…
Copilot Mar 3, 2026
b89d49d
Add ExcludePdbFiles/CreateSymbolsPackage to EFCore.Tasks, fix Design …
Copilot Mar 3, 2026
da71ac5
Use documented pack extension points
ViktorHofer Mar 3, 2026
13cd225
Simplify EFCore.Tools
ViktorHofer Mar 3, 2026
236ac43
Fix symbols for EFCore.Tools
ViktorHofer Mar 3, 2026
fc86041
dotnet-ef.csproj
ViktorHofer Mar 3, 2026
c629829
EFCore.Tasks
ViktorHofer Mar 3, 2026
4727cb0
Add comment
ViktorHofer Mar 3, 2026
ead25ac
Remove temp change
ViktorHofer Mar 3, 2026
824aca1
Remove prop
ViktorHofer Mar 3, 2026
13b350d
Use live dependency on EFCore.Design
ViktorHofer Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<!-- Disable IsAotCompatible on non-DefaultNetCoreTargetFrameworks even if explicitly enabled or else we'll get NETSDK1210 errors -->
<IsAotCompatible Condition="'$(TargetFramework)' != '$(DefaultNetCoreTargetFramework)'"></IsAotCompatible>
<PackageReadmeFile Condition="'$(PackageReadmeFile)' == '' and Exists('PACKAGE.md')">PACKAGE.md</PackageReadmeFile>
<PackageReadmeFile Condition="'$(PackageReadmeFile)' == '' and Exists('README.md')">README.md</PackageReadmeFile>
</PropertyGroup>

<ItemGroup Condition="'$(PackageReadmeFile)' != ''">
Expand Down
26 changes: 26 additions & 0 deletions eng/CreateSymbolsPackage.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<Project>

<!--
Creates a symbols package (.symbols.nupkg) containing PDB files by running a second Pack
with _IsSymbolsPack=true. Projects that import this file should:
1. Set IncludeSymbols=false
2. Include PDB files unconditionally in _PackageFiles
3. Add an ExcludePdbFiles target that strips all .pdb files when _IsSymbolsPack!=true
-->

<Target Name="CreateSymbolsPackage" AfterTargets="Pack"
Condition="'$(_IsSymbolsPack)' != 'true' and '$(IsPackable)' != 'false'">
<PropertyGroup>
<_SymbolsPackTempDir>$([MSBuild]::NormalizeDirectory('$(IntermediateOutputPath)', 'symbolspkg'))</_SymbolsPackTempDir>
</PropertyGroup>
<MakeDir Directories="$(_SymbolsPackTempDir)" />
<MSBuild Projects="$(MSBuildProjectFullPath)"
Targets="Pack"
Properties="_IsSymbolsPack=true;PackageOutputPath=$(_SymbolsPackTempDir)" />
<Copy SourceFiles="$(_SymbolsPackTempDir)$(PackageId).$(PackageVersion).nupkg"
DestinationFiles="$(PackageOutputAbsolutePath)$(PackageId).$(PackageVersion).symbols.nupkg"
OverwriteReadOnlyFiles="true" />
<RemoveDir Directories="$(_SymbolsPackTempDir)" ContinueOnError="true" />
</Target>

</Project>
0 src/EFCore.Abstractions/PACKAGE.md → src/EFCore.Abstractions/README.md
View file
Open in desktop
File renamed without changes.
1 change: 0 additions & 1 deletion src/EFCore.Analyzers/EFCore.Analyzers.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)..\..\rulesets\EFCore.noxmldocs.ruleset</CodeAnalysisRuleSet>
<ImplicitUsings>true</ImplicitUsings>
<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
<PackageReadmeFile>README.md</PackageReadmeFile>
<NoWarn>$(NoWarn);NU5128</NoWarn>
<NoWarn>$(NoWarn);RS1038</NoWarn> <!-- Compiler extensions should be implemented in assemblies with compiler-provided references, #35752 -->
</PropertyGroup>
Expand Down
0 src/EFCore.Cosmos/PACKAGE.md → src/EFCore.Cosmos/README.md
View file
Open in desktop
File renamed without changes.
0 src/EFCore.Design/PACKAGE.md → src/EFCore.Design/README.md
View file
Open in desktop
File renamed without changes.
0 src/EFCore.InMemory/PACKAGE.md → src/EFCore.InMemory/README.md
View file
Open in desktop
File renamed without changes.
0 src/EFCore.Proxies/PACKAGE.md → src/EFCore.Proxies/README.md
View file
Open in desktop
File renamed without changes.
0 src/EFCore.Relational/PACKAGE.md → src/EFCore.Relational/README.md
View file
Open in desktop
File renamed without changes.
0 src/EFCore.SqlServer.Abstractions/PACKAGE.md → src/EFCore.SqlServer.Abstractions/README.md
View file
Open in desktop
File renamed without changes.
0 src/EFCore.SqlServer.HierarchyId/PACKAGE.md → src/EFCore.SqlServer.HierarchyId/README.md
View file
Open in desktop
File renamed without changes.
0 src/EFCore.SqlServer.NTS/PACKAGE.md → src/EFCore.SqlServer.NTS/README.md
View file
Open in desktop
File renamed without changes.
0 src/EFCore.SqlServer/PACKAGE.md → src/EFCore.SqlServer/README.md
View file
Open in desktop
File renamed without changes.
0 src/EFCore.Sqlite.Core/PACKAGE.md → src/EFCore.Sqlite.Core/README.md
View file
Open in desktop
File renamed without changes.
0 src/EFCore.Sqlite.NTS/PACKAGE.md → src/EFCore.Sqlite.NTS/README.md
View file
Open in desktop
File renamed without changes.
0 src/EFCore.Sqlite/PACKAGE.md → src/EFCore.Sqlite/README.md
View file
Open in desktop
File renamed without changes.
55 changes: 37 additions & 18 deletions src/EFCore.Tasks/EFCore.Tasks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@
<Description>MSBuild tasks for Entity Framework Core projects.</Description>
<AssemblyName>Microsoft.EntityFrameworkCore.Tasks</AssemblyName>
<RootNamespace>Microsoft.EntityFrameworkCore</RootNamespace>
<!-- Symbols package is created separately by eng/CreateSymbolsPackage.targets -->
<IncludeSymbols>false</IncludeSymbols>
Comment thread
AndriySvyryd marked this conversation as resolved.
Outdated
<IncludeBuildOutput>false</IncludeBuildOutput>
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
<GenerateDependencyFile>true</GenerateDependencyFile>
<SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
<DevelopmentDependency>true</DevelopmentDependency>
<NoWarn>$(NoWarn);NU5100;NU5128</NoWarn>
<ImplicitUsings>true</ImplicitUsings>
Expand Down Expand Up @@ -45,7 +46,13 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\ef\ef.csproj" ReferenceOutputAssembly="false" />
<ProjectReference Include="..\ef\ef.csproj" ReferenceOutputAssembly="false" PrivateAssets="all" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == '$(NetCurrent)'">
<ProjectReference Include="..\EFCore.Design\EFCore.Design.csproj" PrivateAssets="all" />
<!-- Declare package dependency on Design; VersionOverride needed because the package isn't in Directory.Packages.props -->
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" VersionOverride="10.0.0" />
Comment thread
AndriySvyryd marked this conversation as resolved.
Outdated
Comment thread
ViktorHofer marked this conversation as resolved.
Outdated
</ItemGroup>

<ItemGroup Condition="'$(TargetFrameworkIdentifier)' != '.NETFramework'">
Expand All @@ -54,32 +61,44 @@

<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
<PackageReference Include="System.Text.Json" PrivateAssets="All" />
<Reference Include="Microsoft.Build" />
<Reference Include="Microsoft.Build.Framework" />
<Reference Include="Microsoft.Build.Utilities.v4.0" />
<Reference Include="Microsoft.CSharp" />
<Reference Include="System.Configuration" />
<Reference Include="Microsoft.Build" Pack="false" />
<Reference Include="Microsoft.Build.Framework" Pack="false" />
<Reference Include="Microsoft.Build.Utilities.v4.0" Pack="false" />
<Reference Include="Microsoft.CSharp" Pack="false" />
<Reference Include="System.Configuration" Pack="false" />
</ItemGroup>

<!--
Workaround for insufficient support for task packages by NuGet Pack: https://github.com/NuGet/Home/issues/6321
and bugs with ProjectReference: https://github.com/NuGet/Home/issues/10907, https://github.com/NuGet/Home/issues/10312
-->
<PropertyGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
<SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
</PropertyGroup>

<PropertyGroup>
<NoPackageAnalysis>true</NoPackageAnalysis>
<NuspecFile>$(MSBuildThisFileDirectory)$(MSBuildProjectName).nuspec</NuspecFile>
</PropertyGroup>

<Target Name="SetPackageProperties" BeforeTargets="InitializeStandardNuspecProperties" DependsOnTargets="Build">
<Target Name="AddPackContent" BeforeTargets="GenerateNuspec" DependsOnTargets="Build">
<ItemGroup>
<NuspecProperty Include="AssemblyName=$(AssemblyName)" />
<NuspecProperty Include="OutputPath=$(OutputPath)" />
<NuspecProperty Include="NetCurrent=$(NetCurrent)" />
<NuspecProperty Include="NetFrameworkToolCurrent=$(NetFrameworkToolCurrent)" />
<NuspecProperty Include="EFOutputPath=$(ArtifactsBinDir)ef\$(Configuration)\$(NetMinimum)" />
<_PackageFiles Include="lib/**/*" PackagePath="lib/" />
<_PackageFiles Include="$(ArtifactsBinDir)ef/$(Configuration)/$(NetMinimum)/*" PackagePath="tools/$(NetCurrent)/" />
<_PackageFiles Include="buildTransitive/*" PackagePath="buildTransitive/" />
<_PackageFiles Include="$(OutputPath)$(NetCurrent)/$(AssemblyName).dll" PackagePath="tasks/$(NetCurrent)/" />
<_PackageFiles Include="$(OutputPath)$(NetCurrent)/$(AssemblyName).pdb" PackagePath="tasks/$(NetCurrent)/" />
<_PackageFiles Include="$(OutputPath)$(NetCurrent)/$(AssemblyName).deps.json" PackagePath="tasks/$(NetCurrent)/" />
<_PackageFiles Include="$(OutputPath)$(NetFrameworkToolCurrent)/*" PackagePath="tasks/$(NetFrameworkToolCurrent)/" />
</ItemGroup>
</Target>

<!-- Strip all PDB files from the main package; they are included in the symbols package -->
<Target Name="ExcludePdbFiles" BeforeTargets="GenerateNuspec"
DependsOnTargets="AddPackContent"
Condition="'$(_IsSymbolsPack)' != 'true'">
<ItemGroup>
<_PackageFiles Remove="@(_PackageFiles)" Condition="'%(Extension)' == '.pdb'" />
</ItemGroup>
</Target>

<Import Project="..\..\eng\CreateSymbolsPackage.targets" />

<ItemGroup>
<Service Include="{508349b6-6b84-4df5-91f0-309beebad82d}" />
</ItemGroup>
Expand Down
23 changes: 0 additions & 23 deletions src/EFCore.Tasks/EFCore.Tasks.nuspec
View file
Open in desktop

This file was deleted.

0 src/EFCore.Tasks/PACKAGE.md → src/EFCore.Tasks/README.md
View file
Open in desktop
File renamed without changes.
Empty file added src/EFCore.Tasks/lib/net10.0/_._
View file
Open in desktop

@ViktorHofer ViktorHofer Mar 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a change to the current package on nuget.org. Why adding a placeholder file?

@AndriySvyryd AndriySvyryd Mar 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For same reason as the .Tools package. But this is also likely going to be removed.

Empty file.
0 src/EFCore.Templates/PACKAGE.md → src/EFCore.Templates/README.md
View file
Open in desktop
File renamed without changes.
39 changes: 28 additions & 11 deletions src/EFCore.Tools/EFCore.Tools.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
<PropertyGroup>
<TargetFramework>$(NetMinimum)</TargetFramework>
<PackageId>Microsoft.EntityFrameworkCore.Tools</PackageId>
<NuspecFile>$(MSBuildThisFileDirectory)$(MSBuildProjectName).nuspec</NuspecFile>
<DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences>
<SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
<NoPackageAnalysis>true</NoPackageAnalysis>
<DevelopmentDependency>true</DevelopmentDependency>
<IncludeBuildOutput>false</IncludeBuildOutput>
<IncludeSource>false</IncludeSource>
<IncludeSymbols>true</IncludeSymbols>
<!-- Symbols package is created separately by eng/CreateSymbolsPackage.targets -->
<IncludeSymbols>false</IncludeSymbols>
<Description>Entity Framework Core Tools for the NuGet Package Manager Console in Visual Studio.

Enables these commonly used commands:
Expand All @@ -31,28 +30,46 @@ Update-Database
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\ef\ef.csproj" ReferenceOutputAssembly="false" />
<ProjectReference Include="..\ef\ef.csproj" ReferenceOutputAssembly="false" PrivateAssets="all" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.DotNet.Build.Tasks.Templating" PrivateAssets="All" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" VersionOverride="8.0.0" />

@ViktorHofer ViktorHofer Mar 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndriySvyryd this change is questionable. What's the intent? Why 8.0.0?

@ViktorHofer ViktorHofer Mar 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my last commit. I added a stub project that makes referencing the live EFCore.Design work from this project, even though it targets net10.0. This is a hack though. I'm not sure why this design was chosen in the first place.

@AndriySvyryd AndriySvyryd Mar 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tools need to work with older versions of EF and 8.0.0 is currently the oldest supported version. Referencing the live one will break support for net8.0 apps, see #37515 (comment)

However, I do realize this is brittle anyway, so #37739 tracks removing it and forcing the user to add this dependency themselves, I just wanted to do it in a separate PR to allow this to be checked in quicker.

</ItemGroup>

<ItemGroup>
<GeneratedContent Include="*.psd1.in" />
</ItemGroup>

<!--
Workaround for insufficient support for tools packages by NuGet Pack: https://github.com/NuGet/Home/issues/6321.
-->
<Target Name="SetPackageProperties" BeforeTargets="InitializeStandardNuspecProperties" DependsOnTargets="Build">
<Target Name="AddPackContent" BeforeTargets="GenerateNuspec" DependsOnTargets="GenerateContent">
<ItemGroup>
<NuspecProperty Include="configuration=$(Configuration)" />
<NuspecProperty Include="intermediateOutputPath=$(IntermediateOutputPath)" />
<NuspecProperty Include="targetFramework=$(TargetFramework)" />
<_PackageFiles Include="lib/**/*" PackagePath="lib/" />
<_PackageFiles Include="tools/**/*" PackagePath="tools/" />
<_PackageFiles Include="$(IntermediateOutputPath)*.psd1" PackagePath="tools/" />
<_PackageFiles Include="$(ArtifactsBinDir)ef/$(Configuration)/net472/ef.exe" PackagePath="tools/net472/any/" />
<_PackageFiles Include="$(ArtifactsBinDir)ef/$(Configuration)/net472/ef.pdb" PackagePath="tools/net472/any/" />
<_PackageFiles Include="$(ArtifactsBinDir)ef/x86/$(Configuration)/net472/ef.exe" PackagePath="tools/net472/win-x86/" />
<_PackageFiles Include="$(ArtifactsBinDir)ef/x86/$(Configuration)/net472/ef.pdb" PackagePath="tools/net472/win-x86/" />
<_PackageFiles Include="$(ArtifactsBinDir)ef/ARM64/$(Configuration)/net472/ef.exe" PackagePath="tools/net472/win-arm64/" />
<_PackageFiles Include="$(ArtifactsBinDir)ef/ARM64/$(Configuration)/net472/ef.pdb" PackagePath="tools/net472/win-arm64/" />
<_PackageFiles Include="$(ArtifactsBinDir)ef/$(Configuration)/$(TargetFramework)/ef.dll" PackagePath="tools/$(TargetFramework)/any/" />
<_PackageFiles Include="$(ArtifactsBinDir)ef/$(Configuration)/$(TargetFramework)/ef.pdb" PackagePath="tools/$(TargetFramework)/any/" />
<_PackageFiles Include="$(ArtifactsBinDir)ef/$(Configuration)/$(TargetFramework)/ef.runtimeconfig.json" PackagePath="tools/$(TargetFramework)/any/" />
</ItemGroup>
</Target>

<!-- Strip all PDB files from the main package; they are included in the symbols package -->
<Target Name="ExcludePdbFiles" BeforeTargets="GenerateNuspec"
DependsOnTargets="AddPackContent"
Condition="'$(_IsSymbolsPack)' != 'true'">
<ItemGroup>
<_PackageFiles Remove="@(_PackageFiles)" Condition="'%(Extension)' == '.pdb'" />
</ItemGroup>
</Target>

<Import Project="..\..\eng\CreateSymbolsPackage.targets" />

<Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk" />

<Target Name="GenerateContent"
Expand Down
29 changes: 0 additions & 29 deletions src/EFCore.Tools/EFCore.Tools.nuspec
View file
Open in desktop

This file was deleted.

0 src/EFCore.Tools/PACKAGE.md → src/EFCore.Tools/README.md
View file
Open in desktop
File renamed without changes.
0 src/EFCore/PACKAGE.md → src/EFCore/README.md
View file
Open in desktop
File renamed without changes.
0 src/Microsoft.Data.Sqlite/PACKAGE.md → src/Microsoft.Data.Sqlite/README.md
View file
Open in desktop
File renamed without changes.
0 src/dotnet-ef/PACKAGE.md → src/dotnet-ef/README.md
View file
Open in desktop
File renamed without changes.
45 changes: 23 additions & 22 deletions src/dotnet-ef/dotnet-ef.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,10 @@
<OutputType>Exe</OutputType>
<PackAsTool>true</PackAsTool>
<PackAsToolShimRuntimeIdentifiers>win-x64;win-x86;win-arm64</PackAsToolShimRuntimeIdentifiers>
<!-- Because this project uses a custom nuspec, this is necessary to ensure the generated shims are in the publish directory. -->
<PackagedShimOutputRootDirectory>$(OutDir)</PackagedShimOutputRootDirectory>
<RootNamespace>Microsoft.EntityFrameworkCore.Tools</RootNamespace>
<IncludeSource>false</IncludeSource>
<NuspecFile>$(MSBuildProjectName).nuspec</NuspecFile>
<!-- Symbols package is created separately by eng/CreateSymbolsPackage.targets -->
<IncludeSymbols>false</IncludeSymbols>
Comment thread
AndriySvyryd marked this conversation as resolved.
Outdated
<RollForward>Major</RollForward>
<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)..\..\rulesets\EFCore.noxmldocs.ruleset</CodeAnalysisRuleSet>
<ImplicitUsings>true</ImplicitUsings>
Expand All @@ -48,7 +47,7 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\ef\ef.csproj" ReferenceOutputAssembly="false" />
<ProjectReference Include="..\ef\ef.csproj" ReferenceOutputAssembly="false" PrivateAssets="all" />
</ItemGroup>

<ItemGroup>
Expand All @@ -70,26 +69,28 @@
</Compile>
</ItemGroup>

<Target Name="SetPackageProperties" BeforeTargets="InitializeStandardNuspecProperties" DependsOnTargets="BuiltProjectOutputGroup;DebugSymbolsProjectOutputGroup">
<PropertyGroup>
<!-- Make sure we create a symbols.nupkg. -->
<IncludeSymbols>true</IncludeSymbols>
</PropertyGroup>
<Target Name="AddEfProjectOutput" BeforeTargets="GenerateNuspec">
<ItemGroup>
<_PackageFiles Include="$(ArtifactsBinDir)ef/$(Configuration)/$(TargetFramework)/ef.dll" PackagePath="tools/$(TargetFramework)/any/tools/$(TargetFramework)/any/" />
<_PackageFiles Include="$(ArtifactsBinDir)ef/$(Configuration)/$(TargetFramework)/ef.runtimeconfig.json" PackagePath="tools/$(TargetFramework)/any/tools/$(TargetFramework)/any/" />
<_PackageFiles Include="$(ArtifactsBinDir)ef/$(Configuration)/$(TargetFramework)/ef.pdb" PackagePath="tools/$(TargetFramework)/any/tools/$(TargetFramework)/any/" />
<_PackageFiles Include="$(ArtifactsBinDir)ef/$(Configuration)/net472/ef.exe" PackagePath="tools/$(TargetFramework)/any/tools/net472/any/" />
<_PackageFiles Include="$(ArtifactsBinDir)ef/$(Configuration)/net472/ef.pdb" PackagePath="tools/$(TargetFramework)/any/tools/net472/any/" />
<_PackageFiles Include="$(ArtifactsBinDir)ef/x86/$(Configuration)/net472/ef.exe" PackagePath="tools/$(TargetFramework)/any/tools/net472/win-x86/" />
<_PackageFiles Include="$(ArtifactsBinDir)ef/x86/$(Configuration)/net472/ef.pdb" PackagePath="tools/$(TargetFramework)/any/tools/net472/win-x86/" />
<_PackageFiles Include="$(ArtifactsBinDir)ef/ARM64/$(Configuration)/net472/ef.exe" PackagePath="tools/$(TargetFramework)/any/tools/net472/win-arm64/" />
<_PackageFiles Include="$(ArtifactsBinDir)ef/ARM64/$(Configuration)/net472/ef.pdb" PackagePath="tools/$(TargetFramework)/any/tools/net472/win-arm64/" />
</ItemGroup>
</Target>

<!-- Strip all PDB files from the main package; they are included in the symbols package -->
<Target Name="ExcludePdbFiles" BeforeTargets="GenerateNuspec"
DependsOnTargets="AddEfProjectOutput"
Condition="'$(_IsSymbolsPack)' != 'true'">
<ItemGroup>
<NuspecProperty Include="targetFramework=$(TargetFramework)" />
<NuspecProperty Include="SettingsFile=$(_ToolsSettingsFilePath)" />
<!-- https://github.com/dotnet/msbuild/issues/10715. %2A replaces * working around an issue building Linux. -->
<NuspecProperty Include="Output=$(PublishDir)%2A%2A/%2A" />
<NuspecProperty Include="OutputBinary=..\..\artifacts\bin\ef\$(Configuration)\$(TargetFramework)\ef.dll" />
<NuspecProperty Include="OutputRuntimeConfig=..\..\artifacts\bin\ef\$(Configuration)\$(TargetFramework)\ef.runtimeconfig.json" />
<NuspecProperty Include="OutputSymbol=..\..\artifacts\bin\ef\$(Configuration)\$(TargetFramework)\ef.pdb" />
<NuspecProperty Include="OutputExe=..\..\artifacts\bin\ef\$(Configuration)\net472\ef.exe" />
<NuspecProperty Include="OutputExeSymbol=..\..\artifacts\bin\ef\$(Configuration)\net472\ef.pdb" />
<NuspecProperty Include="OutputX86Exe=..\..\artifacts\bin\ef\x86\$(Configuration)\net472\ef.exe" />
<NuspecProperty Include="OutputX86ExeSymbol=..\..\artifacts\bin\ef\x86\$(Configuration)\net472\ef.pdb" />
<NuspecProperty Include="OutputARM64Exe=..\..\artifacts\bin\ef\ARM64\$(Configuration)\net472\ef.exe" />
<NuspecProperty Include="OutputARM64ExeSymbol=..\..\artifacts\bin\ef\ARM64\$(Configuration)\net472\ef.pdb" />
<_PackageFiles Remove="@(_PackageFiles)" Condition="'%(Extension)' == '.pdb'" />
Comment thread
AndriySvyryd marked this conversation as resolved.
Outdated
</ItemGroup>
</Target>

<Import Project="..\..\eng\CreateSymbolsPackage.targets" />
</Project>
Loading
Loading