[release/10.0] Fix bucketization for number of values between 2070 and 2100 for SQL Server. #37198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cincuranet
changed the title
cincuranet
changed the title
cincuranet
force-pushed
the
fix-2070-release-10
branch
from
68f7360 to
ab9dbd5
Compare
roji
approved these changes
Nov 18, 2025
Member
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
As there aren't multiple actual codepaths here, a single test should be enough to cover this, but LGTM regardless.
cincuranet
force-pushed
the
fix-2070-release-10
branch
from
ab9dbd5 to
f4a223b
Compare
Contributor
Author
|
cc @artl93 |
artl93
approved these changes
Nov 18, 2025
Contributor
Author
|
Approved via email. |
ViktorHofer
changed the title
This was referenced Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #37197.
Description
Incorrect logic was present for bucketization (padding) computation when number of values is between 2070 and 2100 where we want to minimize padding near the limit for SQL Server.
Customer impact
Exception thrown when number of values is between 2070 and 2100.
How found
Customer reported on 10.0.
Regression
Yes.
Testing
Tests added.
Risk
Low. This is a targeted fix. Quirk added.