Skip to content

[automated] Merge branch 'release/8.0' => 'release/9.0' #37088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cincuranet merged 4 commits into from
Nov 6, 2025
Merged

[automated] Merge branch 'release/8.0' => 'release/9.0' #37088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2568567
Merge pull request #36948 from dotnet/release/8.0
cincuranet Oct 10, 2025
a5aec92
Update dependencies (#37048)
AndriySvyryd Nov 4, 2025
a5220c3
Merge branch 'release/8.0-staging' => 'release/8.0' (#37079)
AndriySvyryd Nov 5, 2025
05e8861
Merge branch 'release/9.0' into merge/release/8.0-to-release/9.0
cincuranet Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@
<NoWarn>$(NoWarn.Replace(';1591', ''))</NoWarn>
</PropertyGroup>

<PropertyGroup>
<NuGetAuditLevel>moderate</NuGetAuditLevel>
</PropertyGroup>

<ItemGroup>
<AdditionalFiles Include="$(MSBuildThisFileDirectory)stylecop.json" />
</ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions benchmark/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

<PropertyGroup>
<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)..\rulesets\EFCore.test.ruleset</CodeAnalysisRuleSet>
<NuGetAudit>false</NuGetAudit>
</PropertyGroup>

<ItemGroup>
Expand Down
4 changes: 0 additions & 4 deletions benchmark/EFCore.Sqlite.Benchmarks/EFCore.Sqlite.Benchmarks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@
<ProjectReference Include="..\..\src\EFCore.Sqlite.Core\EFCore.Sqlite.Core.csproj" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="SQLitePCLRaw.bundle_e_sqlite3" />
</ItemGroup>

<ItemGroup>
<None Update="AdventureWorks2014.db">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Proxies/Proxies/Internal/LazyLoadingInterceptor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public virtual void Intercept(IInvocation invocation)
}
else if (LazyLoaderSetter.Equals(invocation.Method))
{
_loader = (ILazyLoader)invocation.Arguments[0];
_loader = (ILazyLoader)invocation.Arguments[0]!;
}
else
{
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Proxies/Proxies/Internal/PropertyChangeInterceptorBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ protected virtual string FindPropertyName(IInvocation invocation)
if (indexerPropertyInfo != null
&& indexerPropertyInfo.GetSetMethod(nonPublic: true) == invocation.Method)
{
return (string)invocation.Arguments[0];
return (string)invocation.Arguments[0]!;
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/EFCore.Proxies/Proxies/Internal/PropertyChangedInterceptor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,12 @@ public virtual void Intercept(IInvocation invocation)
if (methodName == $"add_{nameof(INotifyPropertyChanged.PropertyChanged)}")
{
_handler = (PropertyChangedEventHandler)Delegate.Combine(
_handler, (Delegate)invocation.Arguments[0]);
_handler, (Delegate)invocation.Arguments[0]!);
}
else if (methodName == $"remove_{nameof(INotifyPropertyChanged.PropertyChanged)}")
{
_handler = (PropertyChangedEventHandler?)Delegate.Remove(
_handler, (Delegate)invocation.Arguments[0]);
_handler, (Delegate)invocation.Arguments[0]!);
}
}
else if (methodName.StartsWith("set_", StringComparison.Ordinal))
Expand Down
4 changes: 2 additions & 2 deletions src/EFCore.Proxies/Proxies/Internal/PropertyChangingInterceptor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,12 @@ public virtual void Intercept(IInvocation invocation)
if (methodName == $"add_{nameof(INotifyPropertyChanging.PropertyChanging)}")
{
_handler = (PropertyChangingEventHandler)Delegate.Combine(
_handler, (Delegate)invocation.Arguments[0]);
_handler, (Delegate)invocation.Arguments[0]!);
}
else if (methodName == $"remove_{nameof(INotifyPropertyChanging.PropertyChanging)}")
{
_handler = (PropertyChangingEventHandler?)Delegate.Remove(
_handler, (Delegate)invocation.Arguments[0]);
_handler, (Delegate)invocation.Arguments[0]!);
}
}
else if (methodName.StartsWith("set_", StringComparison.Ordinal))
Expand Down
5 changes: 5 additions & 0 deletions src/ef/ef.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@
<Reference Include="System.Configuration" />
</ItemGroup>

<PropertyGroup>
<!-- Permit targeting `netcoreapp2.0`, see https://github.com/dotnet/efcore/issues/34654 -->
<NoWarn>$(NoWarn);NU1903</NoWarn>
</PropertyGroup>

<ItemGroup>
<!-- Permit targeting `netcoreapp2.0`, see https://github.com/dotnet/efcore/issues/34654 -->
<NuGetAuditSuppress Include="https://github.com/advisories/GHSA-7mfr-774f-w5r9" />
Expand Down
1 change: 1 addition & 0 deletions test/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)..\rulesets\EFCore.test.ruleset</CodeAnalysisRuleSet>
<LangVersion>preview</LangVersion>
<DefaultNetCoreTargetFramework>net9.0</DefaultNetCoreTargetFramework>
<NuGetAudit>false</NuGetAudit>
</PropertyGroup>

</Project>
4 changes: 2 additions & 2 deletions test/EFCore.Cosmos.FunctionalTests/Query/PrimitiveCollectionsQueryCosmosTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1553,11 +1553,11 @@ public override Task Parameter_collection_Concat_column_collection(bool async)

AssertSql(
"""
@__ints_0='[11,111]'
@__p_0='[11,111]'

SELECT VALUE c
FROM root c
WHERE (ARRAY_LENGTH(ARRAY_CONCAT(@__ints_0, c["Ints"])) = 2)
WHERE (ARRAY_LENGTH(ARRAY_CONCAT(@__p_0, c["Ints"])) = 2)
""");
});

Expand Down
2 changes: 1 addition & 1 deletion test/EFCore.Specification.Tests/Query/NorthwindMiscellaneousQueryTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5802,7 +5802,7 @@ public virtual Task Contains_over_concatenated_parameter_and_constant(bool async

return AssertQuery(
async,
ss => ss.Set<Customer>().Where(c => data.Contains(someVariable + "SomeConstant")));
ss => ss.Set<Customer>().Where(c => ((IEnumerable<string>)data).Contains(someVariable + "SomeConstant")));
}

[ConditionalTheory]
Expand Down
2 changes: 1 addition & 1 deletion test/EFCore.Specification.Tests/Query/PrimitiveCollectionsQueryTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,7 @@ public virtual Task Parameter_collection_Concat_column_collection(bool async)

return AssertQuery(
async,
ss => ss.Set<PrimitiveCollectionsEntity>().Where(c => ints.Concat(c.Ints).Count() == 2));
ss => ss.Set<PrimitiveCollectionsEntity>().Where(c => ((IEnumerable<int>)ints).Concat(c.Ints).Count() == 2));
}

[ConditionalTheory] // #33582
Expand Down
6 changes: 3 additions & 3 deletions test/EFCore.SqlServer.FunctionalTests/Query/PrimitiveCollectionsQuerySqlServer160Test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1519,18 +1519,18 @@ public override async Task Parameter_collection_Concat_column_collection(bool as

AssertSql(
"""
@__ints_0='[11,111]' (Size = 4000)
@__p_0='[11,111]' (Size = 4000)

SELECT [p].[Id], [p].[Bool], [p].[Bools], [p].[DateTime], [p].[DateTimes], [p].[Enum], [p].[Enums], [p].[Int], [p].[Ints], [p].[NullableInt], [p].[NullableInts], [p].[NullableString], [p].[NullableStrings], [p].[String], [p].[Strings]
FROM [PrimitiveCollectionsEntity] AS [p]
WHERE (
SELECT COUNT(*)
FROM (
SELECT 1 AS empty
FROM OPENJSON(@__ints_0) AS [i]
FROM OPENJSON(@__p_0) AS [p0]
UNION ALL
SELECT 1 AS empty
FROM OPENJSON([p].[Ints]) AS [i0]
FROM OPENJSON([p].[Ints]) AS [i]
) AS [u]) = 2
""");
}
Expand Down
6 changes: 3 additions & 3 deletions test/EFCore.SqlServer.FunctionalTests/Query/PrimitiveCollectionsQuerySqlServerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1542,18 +1542,18 @@ public override async Task Parameter_collection_Concat_column_collection(bool as

AssertSql(
"""
@__ints_0='[11,111]' (Size = 4000)
@__p_0='[11,111]' (Size = 4000)

SELECT [p].[Id], [p].[Bool], [p].[Bools], [p].[DateTime], [p].[DateTimes], [p].[Enum], [p].[Enums], [p].[Int], [p].[Ints], [p].[NullableInt], [p].[NullableInts], [p].[NullableString], [p].[NullableStrings], [p].[String], [p].[Strings]
FROM [PrimitiveCollectionsEntity] AS [p]
WHERE (
SELECT COUNT(*)
FROM (
SELECT 1 AS empty
FROM OPENJSON(@__ints_0) AS [i]
FROM OPENJSON(@__p_0) AS [p0]
UNION ALL
SELECT 1 AS empty
FROM OPENJSON([p].[Ints]) AS [i0]
FROM OPENJSON([p].[Ints]) AS [i]
) AS [u]) = 2
""");
}
Expand Down
6 changes: 3 additions & 3 deletions test/EFCore.Sqlite.FunctionalTests/Query/PrimitiveCollectionsQuerySqliteTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1501,18 +1501,18 @@ await Assert.ThrowsAsync<EqualException>(

AssertSql(
"""
@__ints_0='[11,111]' (Size = 8)
@__p_0='[11,111]' (Size = 8)

SELECT "p"."Id", "p"."Bool", "p"."Bools", "p"."DateTime", "p"."DateTimes", "p"."Enum", "p"."Enums", "p"."Int", "p"."Ints", "p"."NullableInt", "p"."NullableInts", "p"."NullableString", "p"."NullableStrings", "p"."String", "p"."Strings"
FROM "PrimitiveCollectionsEntity" AS "p"
WHERE (
SELECT COUNT(*)
FROM (
SELECT 1
FROM json_each(@__ints_0) AS "i"
FROM json_each(@__p_0) AS "p0"
UNION ALL
SELECT 1
FROM json_each("p"."Ints") AS "i0"
FROM json_each("p"."Ints") AS "i"
) AS "u") = 2
""");
}
Expand Down