[rc2] Stop using JSON_VALUE() RETURNING for uniqueidentifier on SQL Server 2025 #36740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can we have a reviewer other than me? |
src/EFCore.SqlServer/Query/Internal/SqlServerQuerySqlGenerator.cs
Outdated
Show resolved
Hide resolved
test/EFCore.SqlServer.FunctionalTests/Query/JsonQueryJsonTypeSqlServerTest.cs
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Sep 10, 2025
…2025 And extend type tests to cover this. Fixes dotnet#36627
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is based on top of #36730, review last commit only
Fixes #36627
Description
We added support for SQL Server 2025's JSON data type, which enhances the JSON_VALUE() support to include a RETURNING clause which types the data being extracted out of JSON documents. Unfortunately, the GUID data type specifically (uniqueidentifier) is not supported by SQL Server with the new RETURNING clause, so this PR falls back to the older typing mechanism via a CAST.
Customer impact
Without this PR, some queries involving a GUID value stored within JSON complex types fail when targeting SQL Server 2025 with the new JSON data type (mainline 10 scenario).
How found
Testing
Regression
No
Testing
Added, extended type tests to cover this.
Risk
Very low, trivial one-line change in new codepath.