Skip to content

Add proper handling when a property’s backing field cannot be inferred or the unsafe accessor cannot be generated. #36720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add proper handling when a property’s backing field cannot be inferred or the unsafe accessor cannot be generated. #36720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbb32c0
Proper exception handling for RegisterPrivateAccessor()
kawasaniac Sep 7, 2025
e14d1e2
Update src/EFCore.Design/Properties/DesignStrings.resx
kawasaniac Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/EFCore.Design/Properties/DesignStrings.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions src/EFCore.Design/Properties/DesignStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,9 @@
<data name="CompilationMustBeLoaded" xml:space="preserve">
<value>A compilation must be loaded.</value>
</data>
<data name="CompiledModelBackingFieldNotFound" xml:space="preserve">
<value>Backing field for property '{entityType}.{propertyName}' could not be inferred. Use a matching field name or configure with 'HasField()'.</value>
</data>
<data name="CompiledModelConstructorBinding" xml:space="preserve">
<value>The entity type '{entityType}' has a custom constructor binding. Compiled model can't be generated, because custom constructor bindings are not supported. Configure the custom constructor binding in '{customize}' in a partial '{className}' class instead.</value>
</data>
Expand All @@ -168,6 +171,9 @@
<data name="CompiledModelQueryFilter" xml:space="preserve">
<value>The entity type '{entityType}' has a query filter configured. Compiled model can't be generated, because query filters are not supported.</value>
</data>
<data name="CompiledModelUnsafeAccessorNull" xml:space="preserve">
<value>Unsafe accessor for property '{entityType}.{propertyName}' could not be generated. Ensure the property can be accessed or has a matching backing field.</value>
</data>
<data name="CompiledModelValueGenerator" xml:space="preserve">
<value>The property '{entityType}.{property}' has a value generator configured. Use '{method}' to configure the value generator factory type.</value>
</data>
Expand Down
8 changes: 6 additions & 2 deletions src/EFCore.Design/Scaffolding/Internal/CSharpRuntimeModelCodeGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1769,7 +1769,9 @@ private void RegisterPrivateAccessors(
Dictionary<Type, HashSet<MemberInfo>> unsafeAccessorTypes,
ref Dictionary<MemberInfo, QualifiedName>? memberAccessReplacements)
{
var member = property.GetMemberInfo(forMaterialization, forSet);
var member = property.GetMemberInfo(forMaterialization, forSet) ?? throw new InvalidOperationException(
DesignStrings.CompiledModelBackingFieldNotFound(property.DeclaringType.ShortName(), property.Name));

switch (member)
{
case FieldInfo field:
Expand Down Expand Up @@ -1799,7 +1801,9 @@ private void RegisterPrivateAccessors(
}

memberAccessReplacements ??= [];
var methodName = LinqToCSharpSyntaxTranslator.GetUnsafeAccessorName(member);

var methodName = LinqToCSharpSyntaxTranslator.GetUnsafeAccessorName(member) ?? throw new InvalidOperationException(
DesignStrings.CompiledModelUnsafeAccessorNull(property.DeclaringType.ShortName(), property.Name));

var declaringType = member.DeclaringType!;
if (declaringType.IsGenericType
Expand Down
Loading