Skip to content

Skip flaky SQL Server database deletion tests #36579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndriySvyryd merged 1 commit into from
Aug 15, 2025
Merged

Skip flaky SQL Server database deletion tests #36579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/EFCore.SqlServer.FunctionalTests/SqlServerDatabaseCreatorTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ await context.Database.CreateExecutionStrategy().ExecuteAsync(
[SqlServerCondition(SqlServerCondition.IsNotCI)]

@AndriySvyryd AndriySvyryd Aug 14, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be already skipped on CI, perhaps what broke was this condition

@roji roji Aug 14, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, interesting...

public class SqlServerDatabaseCreatorEnsureDeletedTest : SqlServerDatabaseCreatorTestBase
{
[ConditionalTheory]
[ConditionalTheory(Skip = "#36578")]
[InlineData(true, true, true)]
[InlineData(false, false, true)]
[InlineData(true, false, false)]
Expand Down Expand Up @@ -435,7 +435,7 @@ await GetExecutionStrategy(testDatabase).ExecuteAsync(
[SqlServerCondition(SqlServerCondition.IsNotCI)]
public class SqlServerDatabaseCreatorDeleteTest : SqlServerDatabaseCreatorTestBase
{
[ConditionalTheory]
[ConditionalTheory(Skip = "#36578")]
[InlineData(true, true)]
[InlineData(false, false)]
public static async Task Deletes_database(bool async, bool ambientTransaction)
Expand Down
Loading