Fix the EFCore NuGet package to properly depend on the Analyzers package

[AndriySvyryd]

Fixes #36555

[Copilot]

Pull Request Overview

This PR fixes the NuGet package dependency configuration for the EFCore package to properly include the Analyzers package as a dependency. The change modifies how the EFCore.Analyzers project reference is handled in the build process.

Key changes:

• Updates the project reference configuration for EFCore.Analyzers to use PrivateAssets instead of ReferenceOutputAssembly="False" OutputItemType="Analyzer"

Comments suppressed due to low confidence (1)

src/EFCore/EFCore.csproj:56

• The PrivateAssets configuration may not properly handle analyzer dependencies. For analyzer packages, consider using PrivateAssets="all" and IncludeAssets="runtime; build; native; contentfiles; analyzers" to ensure the analyzer is properly included in the consuming package while preventing transitive dependencies.

    <ProjectReference Include="..\EFCore.Analyzers\EFCore.Analyzers.csproj" PrivateAssets="contentfiles;build" />

---

_{You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.}

[roji]

Odd, I'm pretty sure there was documentation showing OutputItemType="Analyzer".

[AndriySvyryd]

Odd, I'm pretty sure there was documentation showing OutputItemType="Analyzer".

Was it showing how to reference an analyzer or how to depend on an analyzer? 🤔

[roji]

I'm not sure anymore... But I originally submitted #34596 (which caused the problem) to deal with trouble around EFDiagnostics, and everything still seems fine around that, so it seems like we're good on all fronts...