Code cleanup for src

src/Directory.Build.props

@@ -13,4 +13,4 @@
     <PackageReference Include="DotNetAnalyzers.DocumentationAnalyzers" PrivateAssets="All" />
   </ItemGroup>
 
-</Project>
+</Project>

src/EFCore.Abstractions/ChangeTracking/Internal/ObservableBackedBindingList.cs

@@ -14,8 +14,8 @@ namespace Microsoft.EntityFrameworkCore.ChangeTracking.Internal;
 ///     doing so can result in application failures when updating to a new Entity Framework Core release.
 /// </summary>
 [RequiresUnreferencedCode(
-    "BindingList raises ListChanged events with PropertyDescriptors. PropertyDescriptors require unreferenced code.")]
-[RequiresDynamicCode("Requires calling MakeGenericType on the property descriptor's type")]
+     "BindingList raises ListChanged events with PropertyDescriptors. PropertyDescriptors require unreferenced code."),
+ RequiresDynamicCode("Requires calling MakeGenericType on the property descriptor's type")]
 public class ObservableBackedBindingList<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] T> : SortableBindingList<T>
 {
     private bool _addingNewInstance;

src/EFCore.Abstractions/ChangeTracking/Internal/SortableBindingList.cs

@@ -13,8 +13,8 @@ namespace Microsoft.EntityFrameworkCore.ChangeTracking.Internal;
 ///     any release. You should only use it directly in your code with extreme caution and knowing that
 ///     doing so can result in application failures when updating to a new Entity Framework Core release.
 /// </summary>
-[RequiresUnreferencedCode("Raises ListChanged events with PropertyDescriptors. PropertyDescriptors require unreferenced code.")]
-[RequiresDynamicCode("Requires calling MakeGenericType on the property descriptor's type")]
+[RequiresUnreferencedCode("Raises ListChanged events with PropertyDescriptors. PropertyDescriptors require unreferenced code."),
+ RequiresDynamicCode("Requires calling MakeGenericType on the property descriptor's type")]
 public class SortableBindingList<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] T> : BindingList<T>
 {
     private bool _isSorted;
@@ -39,18 +39,16 @@ public SortableBindingList(List<T> list)
     ///     any release. You should only use it directly in your code with extreme caution and knowing that
     ///     doing so can result in application failures when updating to a new Entity Framework Core release.
     /// </summary>
-    [RequiresUnreferencedCode("Requires accessing property 'Default' on the property descriptor's type")]
-    [RequiresDynamicCode("Requires calling MakeGenericType on the property descriptor's type")]
-    [UnconditionalSuppressMessage(
-        "ReflectionAnalysis",
-        "IL2046",
-        Justification =
-            "This method is an override, and the base method isn't annotated with RequiresUnreferencedCode. "
-            + "The entire type is marked with RequiresUnreferencedCode.")]
-    [SuppressMessage(
-        "AOT", "IL3051:'RequiresDynamicCodeAttribute' annotations must match across all interface implementations or overrides.",
-        Justification = "This method is an override, and the base method isn't annotated with RequiresDynamicCode. "
-            + "The entire type is marked with RequiresDynamicCode.")]
+    [RequiresUnreferencedCode("Requires accessing property 'Default' on the property descriptor's type"),
+     RequiresDynamicCode("Requires calling MakeGenericType on the property descriptor's type"), UnconditionalSuppressMessage(
+         "ReflectionAnalysis",
+         "IL2046",
+         Justification =
+             "This method is an override, and the base method isn't annotated with RequiresUnreferencedCode. "
+             + "The entire type is marked with RequiresUnreferencedCode."), SuppressMessage(
+         "AOT", "IL3051:'RequiresDynamicCodeAttribute' annotations must match across all interface implementations or overrides.",
+         Justification = "This method is an override, and the base method isn't annotated with RequiresDynamicCode. "
+             + "The entire type is marked with RequiresDynamicCode.")]
     protected override void ApplySortCore(PropertyDescriptor prop, ListSortDirection direction)
     {
         if (PropertyComparer.CanSort(prop.PropertyType))
@@ -117,8 +115,8 @@ private sealed class PropertyComparer : Comparer<T>
         private readonly ListSortDirection _direction;
         private readonly PropertyDescriptor _prop;
 
-        [RequiresUnreferencedCode("Requires accessing property 'Default' on the property descriptor's type")]
-        [RequiresDynamicCode("Requires calling MakeGenericType on the property descriptor's type")]
+        [RequiresUnreferencedCode("Requires accessing property 'Default' on the property descriptor's type"),
+         RequiresDynamicCode("Requires calling MakeGenericType on the property descriptor's type")]
         public PropertyComparer(PropertyDescriptor prop, ListSortDirection direction)
         {
             if (!prop.ComponentType.IsAssignableFrom(typeof(T)))

src/EFCore.Abstractions/ChangeTracking/ObservableCollectionListSource.cs

@@ -75,18 +75,16 @@ bool IListSource.ContainsListCollection
     ///     An <see cref="IBindingList" /> in sync with the ObservableCollection.
     /// </returns>
     [RequiresUnreferencedCode(
-        "BindingList raises ListChanged events with PropertyDescriptors. PropertyDescriptors require unreferenced code.")]
-    [RequiresDynamicCode("Requires calling MakeGenericType on the property descriptor's type")]
-    [UnconditionalSuppressMessage(
-        "ReflectionAnalysis",
-        "IL2046",
-        Justification =
-            "This method is an interface implementation, and the interface method isn't annotated with RequiresUnreferencedCode. "
-            + "The entire type is marked with RequiresUnreferencedCode.")]
-    [SuppressMessage(
-        "AOT", "IL3051:'RequiresDynamicCodeAttribute' annotations must match across all interface implementations or overrides.",
-        Justification = "This method is an override, and the base method isn't annotated with RequiresDynamicCode. "
-            + "The entire type is marked with RequiresDynamicCode.")]
+         "BindingList raises ListChanged events with PropertyDescriptors. PropertyDescriptors require unreferenced code."),
+     RequiresDynamicCode("Requires calling MakeGenericType on the property descriptor's type"), UnconditionalSuppressMessage(
+         "ReflectionAnalysis",
+         "IL2046",
+         Justification =
+             "This method is an interface implementation, and the interface method isn't annotated with RequiresUnreferencedCode. "
+             + "The entire type is marked with RequiresUnreferencedCode."), SuppressMessage(
+         "AOT", "IL3051:'RequiresDynamicCodeAttribute' annotations must match across all interface implementations or overrides.",
+         Justification = "This method is an override, and the base method isn't annotated with RequiresDynamicCode. "
+             + "The entire type is marked with RequiresDynamicCode.")]
     IList IListSource.GetList()
         => _bindingList ??= this.ToBindingList();
 }

src/EFCore.Abstractions/EntityTypeConfigurationAttribute.cs

@@ -19,7 +19,10 @@ public class EntityTypeConfigurationAttribute : Attribute
     ///     Initializes a new instance of the <see cref="EntityTypeConfigurationAttribute" /> class.
     /// </summary>
     /// <param name="entityConfigurationType">The IEntityTypeConfiguration&lt;&gt; type to use.</param>
-    public EntityTypeConfigurationAttribute([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor | DynamicallyAccessedMemberTypes.Interfaces)] Type entityConfigurationType)
+    public EntityTypeConfigurationAttribute(
+        [DynamicallyAccessedMembers(
+            DynamicallyAccessedMemberTypes.PublicParameterlessConstructor | DynamicallyAccessedMemberTypes.Interfaces)]
+        Type entityConfigurationType)
     {
         Check.NotNull(entityConfigurationType);
 

src/EFCore.Abstractions/ObservableCollectionExtensions.cs

@@ -25,8 +25,8 @@ public static class ObservableCollectionExtensions
     /// <param name="source">The collection that the binding list will stay in sync with.</param>
     /// <returns>The binding list.</returns>
     [RequiresUnreferencedCode(
-        "BindingList raises ListChanged events with PropertyDescriptors. PropertyDescriptors require unreferenced code.")]
-    [RequiresDynamicCode("Requires calling MakeGenericType on the property descriptor's type")]
+         "BindingList raises ListChanged events with PropertyDescriptors. PropertyDescriptors require unreferenced code."),
+     RequiresDynamicCode("Requires calling MakeGenericType on the property descriptor's type")]
     public static BindingList<T> ToBindingList<T>(this ObservableCollection<T> source)
         where T : class
         => new ObservableBackedBindingList<T>(source);

src/EFCore.Analyzers/EFCore.Analyzers.nuspec

@@ -1,4 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
+
 <package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
   <metadata>
     $CommonMetadataElements$
@@ -14,4 +15,4 @@
     <file src="$OutputBinary$" target="analyzers\dotnet\cs\" />
     <file src="$OutputSymbol$" target="analyzers\dotnet\cs\" />
   </files>
-</package>
+</package>

src/EFCore.Analyzers/InternalUsageDiagnosticAnalyzer.cs

@@ -23,7 +23,8 @@ private static readonly DiagnosticDescriptor Descriptor
             defaultSeverity: DiagnosticSeverity.Warning,
             isEnabledByDefault: true);
 
-    public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => [Descriptor];
+    public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
+        => [Descriptor];
 
     public override void Initialize(AnalysisContext context)
     {
@@ -308,14 +309,13 @@ private static bool IsInternal(OperationAnalysisContext context, ITypeSymbol sym
             && (IsInInternalNamespace(symbol) || HasInternalAttribute(symbol));
 
     private static bool HasInternalAttribute(ISymbol symbol)
-        => symbol.GetAttributes().Any(
-            a =>
-                a.AttributeClass!.ToDisplayString()
-                == "Microsoft.EntityFrameworkCore.Infrastructure.EntityFrameworkInternalAttribute");
+        => symbol.GetAttributes().Any(a =>
+            a.AttributeClass!.ToDisplayString()
+            == "Microsoft.EntityFrameworkCore.Infrastructure.EntityFrameworkInternalAttribute");
 
     private static bool IsInInternalNamespace(ISymbol symbol)
     {
-        if (symbol?.ContainingNamespace?.ToDisplayString() is string ns)
+        if (symbol?.ContainingNamespace?.ToDisplayString() is { } ns)
         {
             var i = ns.IndexOf("EntityFrameworkCore", StringComparison.Ordinal);
 

src/EFCore.Analyzers/InterpolatedStringUsageInRawQueriesCodeFixProvider.cs

@@ -11,11 +11,11 @@
 
 namespace Microsoft.EntityFrameworkCore;
 
-[ExportCodeFixProvider(LanguageNames.CSharp, Name = nameof(InterpolatedStringUsageInRawQueriesCodeFixProvider))]
-[Shared]
+[ExportCodeFixProvider(LanguageNames.CSharp, Name = nameof(InterpolatedStringUsageInRawQueriesCodeFixProvider)), Shared]
 public sealed class InterpolatedStringUsageInRawQueriesCodeFixProvider : CodeFixProvider
 {
-    public override ImmutableArray<string> FixableDiagnosticIds => [EFDiagnostics.InterpolatedStringUsageInRawQueries];
+    public override ImmutableArray<string> FixableDiagnosticIds
+        => [EFDiagnostics.InterpolatedStringUsageInRawQueries];
 
     public override FixAllProvider GetFixAllProvider()
         => WellKnownFixAllProviders.BatchFixer;

src/EFCore.Analyzers/InterpolatedStringUsageInRawQueriesDiagnosticAnalyzer.cs

@@ -21,7 +21,8 @@ private static readonly DiagnosticDescriptor Descriptor
             defaultSeverity: DiagnosticSeverity.Warning,
             isEnabledByDefault: true);
 
-    public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => [Descriptor];
+    public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
+        => [Descriptor];
 
     public override void Initialize(AnalysisContext context)
     {

src/EFCore.Cosmos/ChangeTracking/Internal/StringDictionaryComparer.cs

@@ -15,7 +15,8 @@ namespace Microsoft.EntityFrameworkCore.Cosmos.ChangeTracking.Internal;
 public sealed class StringDictionaryComparer<TDictionary, TElement> : ValueComparer<object>, IInfrastructure<ValueComparer>
 {
     private static readonly MethodInfo CompareMethod = typeof(StringDictionaryComparer<TDictionary, TElement>).GetMethod(
-        nameof(Compare), BindingFlags.Static | BindingFlags.NonPublic, [typeof(object), typeof(object), typeof(Func<TElement, TElement, bool>)])!;
+        nameof(Compare), BindingFlags.Static | BindingFlags.NonPublic,
+        [typeof(object), typeof(object), typeof(Func<TElement, TElement, bool>)])!;
 
     private static readonly MethodInfo GetHashCodeMethod = typeof(StringDictionaryComparer<TDictionary, TElement>).GetMethod(
         nameof(GetHashCode), BindingFlags.Static | BindingFlags.NonPublic, [typeof(IEnumerable), typeof(Func<TElement, int>)])!;
@@ -72,7 +73,7 @@ private static Expression<Func<object, int>> GetHashCodeLambda(ValueComparer ele
                 Expression.Convert(
                     prm,
                     typeof(IEnumerable)),
-                    elementComparer.HashCodeExpression),
+                elementComparer.HashCodeExpression),
             prm);
     }
 

src/EFCore.Cosmos/Diagnostics/Internal/CosmosLoggerExtensions.cs

@@ -205,19 +205,18 @@ private static string ExecutedReadNext(EventDefinitionBase definition, EventData
     {
         var d = (FallbackEventDefinition)definition;
         var p = (CosmosQueryExecutedEventData)payload;
-        return d.GenerateMessage(
-            l => l.Log(
-                d.Level,
-                d.EventId,
-                d.MessageFormat,
-                p.Elapsed.TotalMilliseconds,
-                p.RequestCharge,
-                p.ActivityId,
-                p.ContainerId,
-                p.LogSensitiveData ? p.PartitionKeyValue.ToString() : "?",
-                FormatParameters(p.Parameters, p is { LogSensitiveData: true, Parameters.Count: > 0 }),
-                Environment.NewLine,
-                p.QuerySql));
+        return d.GenerateMessage(l => l.Log(
+            d.Level,
+            d.EventId,
+            d.MessageFormat,
+            p.Elapsed.TotalMilliseconds,
+            p.RequestCharge,
+            p.ActivityId,
+            p.ContainerId,
+            p.LogSensitiveData ? p.PartitionKeyValue.ToString() : "?",
+            FormatParameters(p.Parameters, p is { LogSensitiveData: true, Parameters.Count: > 0 }),
+            Environment.NewLine,
+            p.QuerySql));
     }
 
     /// <summary>

src/EFCore.Cosmos/Extensions/CosmosDbFunctionsExtensions.cs

@@ -109,7 +109,7 @@ public static double Rrf(this DbFunctions _, params double[] scores)
     /// <param name="vector2">The second vector.</param>
     /// <param name="useBruteForce">
     ///     An optional boolean specifying how the computed value is used in an <c>ORDER BY</c> expression.
-    ///     If <see langword="true"/>, then brute force is used. A value of <see langword="false" /> uses any index defined on the vector
+    ///     If <see langword="true" />, then brute force is used. A value of <see langword="false" /> uses any index defined on the vector
     ///     property, if it exists. Default value is <see langword="false" />.
     /// </param>
     /// <param name="options">An optional object used to specify options for the vector distance calculation.</param>
@@ -129,7 +129,7 @@ public static double VectorDistance(
     /// <param name="vector2">The second vector.</param>
     /// <param name="useBruteForce">
     ///     An optional boolean specifying how the computed value is used in an <c>ORDER BY</c> expression.
-    ///     If <see langword="true"/>, then brute force is used. A value of <see langword="false" /> uses any index defined on the vector
+    ///     If <see langword="true" />, then brute force is used. A value of <see langword="false" /> uses any index defined on the vector
     ///     property, if it exists. Default value is <see langword="false" />.
     /// </param>
     /// <param name="options">An optional object used to specify options for the vector distance calculation.</param>
@@ -149,7 +149,7 @@ public static double VectorDistance(
     /// <param name="vector2">The second vector.</param>
     /// <param name="useBruteForce">
     ///     An optional boolean specifying how the computed value is used in an <c>ORDER BY</c> expression.
-    ///     If <see langword="true"/>, then brute force is used. A value of <see langword="false" /> uses any index defined on the vector
+    ///     If <see langword="true" />, then brute force is used. A value of <see langword="false" /> uses any index defined on the vector
     ///     property, if it exists. Default value is <see langword="false" />.
     /// </param>
     /// <param name="options">An optional object used to specify options for the vector distance calculation.</param>

src/EFCore.Cosmos/Extensions/CosmosEntityTypeBuilderExtensions.cs

@@ -1020,7 +1020,11 @@ public static bool CanSetThroughput(
     /// <remarks>
     ///     See <see href="https://aka.ms/efcore-docs-triggers">Database triggers</see> for more information and examples.
     /// </remarks>
-    public static TriggerBuilder HasTrigger(this EntityTypeBuilder entityTypeBuilder, string modelName, TriggerType triggerType, TriggerOperation triggerOperation)
+    public static TriggerBuilder HasTrigger(
+        this EntityTypeBuilder entityTypeBuilder,
+        string modelName,
+        TriggerType triggerType,
+        TriggerOperation triggerOperation)
     {
         var triggerBuilder = EntityTypeBuilder.HasTrigger(entityTypeBuilder.Metadata, modelName);
         triggerBuilder.Metadata.SetTriggerType(triggerType);
@@ -1039,7 +1043,11 @@ public static TriggerBuilder HasTrigger(this EntityTypeBuilder entityTypeBuilder
     /// <remarks>
     ///     See <see href="https://aka.ms/efcore-docs-triggers">Database triggers</see> for more information and examples.
     /// </remarks>
-    public static TriggerBuilder HasTrigger<TEntity>(this EntityTypeBuilder<TEntity> entityTypeBuilder, string modelName, TriggerType triggerType, TriggerOperation triggerOperation)
+    public static TriggerBuilder HasTrigger<TEntity>(
+        this EntityTypeBuilder<TEntity> entityTypeBuilder,
+        string modelName,
+        TriggerType triggerType,
+        TriggerOperation triggerOperation)
         where TEntity : class
     {
         var triggerBuilder = EntityTypeBuilder.HasTrigger(entityTypeBuilder.Metadata, modelName);

src/EFCore.Cosmos/Extensions/CosmosEntityTypeExtensions.cs

@@ -80,7 +80,7 @@ public static void SetContainer(this IMutableEntityType entityType, string? name
     }
 
     private static string? GetDefaultContainingPropertyName(IReadOnlyEntityType entityType)
-        => entityType.FindOwnership() is IReadOnlyForeignKey ownership
+        => entityType.FindOwnership() is { } ownership
             ? ownership.PrincipalToDependent!.Name
             : null;
 

src/EFCore.Cosmos/Extensions/CosmosIndexBuilderExtensions.cs

@@ -103,7 +103,8 @@ public static bool CanSetVectorIndexType(
 
     /// <summary>
     ///     Configures the index as a full-text index.
-    ///     See <see href="https://learn.microsoft.com/azure/cosmos-db/gen-ai/full-text-search">Full-text search in Azure Cosmos DB for NoSQL</see> for more information.
+    ///     See <see href="https://learn.microsoft.com/azure/cosmos-db/gen-ai/full-text-search">Full-text search in Azure Cosmos DB for NoSQL</see>
+    ///     for more information.
     /// </summary>
     /// <remarks>
     ///     See <see href="https://aka.ms/efcore-docs-modeling">Modeling entity types and relationships</see>, and
@@ -121,7 +122,8 @@ public static IndexBuilder IsFullTextIndex(this IndexBuilder indexBuilder, bool
 
     /// <summary>
     ///     Configures the index as a full-text index.
-    ///     See <see href="https://learn.microsoft.com/azure/cosmos-db/gen-ai/full-text-search">Full-text search in Azure Cosmos DB for NoSQL</see> for more information.
+    ///     See <see href="https://learn.microsoft.com/azure/cosmos-db/gen-ai/full-text-search">Full-text search in Azure Cosmos DB for NoSQL</see>
+    ///     for more information.
     /// </summary>
     /// <remarks>
     ///     See <see href="https://aka.ms/efcore-docs-modeling">Modeling entity types and relationships</see>, and
@@ -137,7 +139,8 @@ public static IndexBuilder<TEntity> IsFullTextIndex<TEntity>(
 
     /// <summary>
     ///     Configures the index as a full-text index.
-    ///     See <see href="https://learn.microsoft.com/azure/cosmos-db/gen-ai/full-text-search">Full-text search in Azure Cosmos DB for NoSQL</see> for more information.
+    ///     See <see href="https://learn.microsoft.com/azure/cosmos-db/gen-ai/full-text-search">Full-text search in Azure Cosmos DB for NoSQL</see>
+    ///     for more information.
     /// </summary>
     /// <remarks>
     ///     See <see href="https://aka.ms/efcore-docs-modeling">Modeling entity types and relationships</see>, and