Bring JSON type out of experimental status #36442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
SqlServerJson
branch
3 times, most recently
from
50b7c3d to
8812300
Compare
roji
commented
Jul 26, 2025
test/EFCore.SqlServer.FunctionalTests/Query/AdHocJsonQuerySqlServerTestBase.cs
Show resolved
Hide resolved
| // When testing against SQL Server 2025 or later, set the compatibility level to 170 to use the json type instead of nvarchar(max). | ||
| public override DbContextOptionsBuilder AddOptions(DbContextOptionsBuilder builder) | ||
| => UsingJsonType | ||
| ? builder.UseSqlServer(o => o.UseCompatibilityLevel(170)) |
Member
Author
There was a problem hiding this comment.
Note the two different testing strategies:
- These relationship query tests use the same suites to test both new and old SQL Server versions (with different translations), varying the compatibility level based on the actual server being targeted. This means that for full coverage, our CI must run both the newest and the oldest supported SQL Server version.
- Baselines can assert on the different translations (see just below). This is really nice for seeing the differences.
- Less duplication, just one test suite covers both translations (assuming we run against the different versions in CI).
- The alternative is done in PrimitiveCollectionsQuerySqlServerJsonTypeTest, where there's a separate test suite only for the new translations, which gets skipped if the targeted SQL Server doesn't support the feature.
- This causes lots of duplication and is less manageable.
| typeof(string), | ||
| typeMappingSource.FindMapping(typeof(string))!)) | ||
| : base.Visit(expression); | ||
| // The SQL Server json type cannot be compared ("The JSON data type cannot be compared or sorted, except when using the |
Member
Author
There was a problem hiding this comment.
We need to confirm this in design.
Member
Author
There was a problem hiding this comment.
Design decision: we'll go ahead with allowing comparison of JSON-mapped complex types by adding this cast to nvarchar(max):
- This isn't any worse than the already-supported comparison of
nvarchar(max)-mapped types. - As long as EF is used to read/write the columns, everything works.
- We don't want the new
jsonsupport to be inferior to the worstnvarchar(max)mapping option.
| jsonScalar.IsNullable); | ||
| } | ||
|
|
||
| case SqlServerOpenJsonExpression openJsonExpression: |
Member
Author
There was a problem hiding this comment.
Confirmed that this cast is no longer needed - OPENJSON can just directly accept the json data type.
AndriySvyryd
approved these changes
Jul 29, 2025
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* Remove experimental warning * Remove conversion to nvarchar(max) within OPENJSON * Add conversions to nvarchar(max) when comparing json (not natively supported) * Use json type in complex JSON query tests when targeting newer versions of SQL Server * Various test tweaks and cleanup Closes dotnet#36024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36024
/cc @artl93