[release/9.0] Fix Contains on ImmutableArray #35251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
approved these changes
Dec 2, 2024
cincuranet
force-pushed
the
backport-35247
branch
from
b4f755c to
b68b5fd
Compare
cincuranet
force-pushed
the
backport-35247
branch
from
b68b5fd to
43558a4
Compare
|
Approved via email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35102
Backport of #35247
Description
Because of query pipeline internal changes in EF Core 9 we started to improperly handle value type collections - like
ImmutableArray<T>- when pre-processing query's expression tree. Value types require boxing when handled via interfaces (IEnumerable<T>in this case). This boxing conversion/node was missing.Customer impact
Customers using
ImmutableArray<T>(or any collection that's a value type) experience an exception when running their application.How found
Customer reported on 9.
Regression
Yes, from 8.
Testing
Tests added.
Risk
Low.