[release/9.0] Set environment variables to "Development" when creating DbContext using IDesignTimeDbContextFactory #35230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35174
Description
In EF 9.0 we added a short-circuit that avoids creating an
AppHostwhen creating aDbContextusingIDesignTimeDbContextFactory. But this had an unintended side effect of no longer setting the environment variablesASPNETCORE_ENVIRONMENTandDOTNET_ENVIRONMENTtoDevelopmentCustomer impact
Code that relied on a specific environment is broken. A workaround is to set the environment variables manually.
How found
Customer reported on 9.
Regression
Yes, from 8.
Testing
Tests fixed.
Risk
Low.